From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751875AbbKBWBF (ORCPT ); Mon, 2 Nov 2015 17:01:05 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:50111 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbbKBWBC (ORCPT ); Mon, 2 Nov 2015 17:01:02 -0500 From: Arnd Bergmann To: Sinan Kaya Cc: Rob Herring , Timur Tabi , dmaengine@vger.kernel.org, Christopher Covington , "jcm@redhat.com" , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Vinod Koul , Dan Williams , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2 1/3] dma: add Qualcomm Technologies HIDMA management driver Date: Mon, 02 Nov 2015 23:00:38 +0100 Message-ID: <21289988.98iBsIZliz@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <5637B03F.9090905@codeaurora.org> References: <1446444460-21600-1-git-send-email-okaya@codeaurora.org> <5637B03F.9090905@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ccIDj6OcRuiODZxqljFNoLCSmnBhmgX+Xpy3Q2YpXLiqFtcIZn2 FDumZSpMKYadGDEF7w2pFZT7xIDD2tgKNCmAN/B8UZe6pBbSM+mSbTp2W045yCH/MeYc7Tv ZsqIzOHKQantVe3+5WmiLvL1ccSYaribydpn5/y4Zk5eGiGhVspIx/U6hNaSZmzLApa+ULM Tq4Ri+0rgirrQHnVB9ckg== X-UI-Out-Filterresults: notjunk:1;V01:K0:KSB9aVqALPM=:CXpQdhyYHXzj8zI+w4ZvhD WEUCt5SdyWDbGTuqcJbynhiQvsEqMqhl1Ks7FCyTnE9r8l3OpCYDYKwpg9s5D0OpM/L8fGQnd JfM4VgdafsvmSFdfVZM+EJLUmixS4IGg06TZWSTqWhXK1hIpuUeE13SdLj4W3S3ToQgpZ8uae Ee7xvUCN5PYsT9+WDqVoBrc5L6/EmGAEnMWoQi3+BrH+Iy13EBOdJ+8DInXrTC3a5aGdZj5Lt MQyifnoWE6OSg7mlloJA9wt69/UiFX3SHa+Js7gABNXWk40uwWuZGEGHl7GG+G/EIFedSmB3M SiKab3Z7gALcSMX/8o/E8RuxP3HVAaxSTmL59KwN/4tnODglnXsHGEzQqzejFQkHVvSlT2x5w TM0lDd1rP4CCbTVS7IewxuX1F85Ftb7K0TPu/ycG2kneTaNTv1JJnal0ayE0fm9yNYXOe31oK dq5kt+dQoPKQe0tVAS1x8XTGKq4sx8xmA+pV/J9SMXVQkoFpMKnpLOAgO4wo5NMD8bLbR3Pkm yddOIebGAgkK+CQZYKyCgsKcCA031hH0ynOIC1IC5yJTSM4l6pN4PmodkP10fqT9yMiKvj61M uPoNjV0GsyUz6b01BjtHnfu4I69K2n9r0HvkVCuWchJa5yvGbei9Kw7nIFIENuSf2OpM6cAEs /M4nfY5OnWBzQay3+0q/8fOvj8XiP43H0/AdlM0T1zL/dnCTo3PxEpwbFUCx50zCAQf2An1kS LnQ9X9YIob9i/COu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 02 November 2015 13:49:35 Sinan Kaya wrote: > On 11/2/2015 12:42 PM, Rob Herring wrote: > > Except I was suggesting not using 1.0 or 1.1. There is one main > > exception and that is Xilinx blocks, but they are releasing versions > > of blocks to customers. If "1.0" is not a well defined number, then > > don't use that. I'd be surprised if any SOC vendor had such well > > defined process around versioning of their IP blocks such that they > > are well documented and guaranteed such that every change will change > > the version. > > Here is one. > > I have two versions of the same IP. The first version in one chip has > sw_version register that returns 1.0. The second version which has more > capabilities has 1.1 in it. > > Is it OK to use? > > compatible="qcom,hidma-mgmt-1.0", "qcom,hidma-mgmt" > > for now and > > compatible="qcom,hidma-mgmt-1.1", "qcom,hidma-mgmt" > > later for the second chip? 1.1 is backwards compatible with 1.0 BTW. I think this is fine. As they are backwards compatible, I would even make the latter one compatible = "qcom,hidma-mgmt-1.1", "qcom,hidma-mgmt-1.0", "qcom,hidma-mgmt"; > Since the same IP goes into multiple chips, why would you list the chip > name here and submit patches multiple times for each single chip. > > or to follow what Timur did, I can do this. > > "qcom,qdf2xxx-hidma-mgmt-1.0" > > qdf2xxx would become the chip family. We really don't want wildcards in here, but want to use the most specific name you have for it, so we can add quirks to the driver later if it turns out that they are not fully compatible after all. Arnd