From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Julia Lawall <julia.lawall@inria.fr>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove useless led_blink_hdl()
Date: Wed, 14 Apr 2021 15:27:03 +0200 [thread overview]
Message-ID: <2135425.qiX1NcrmH6@linux.local> (raw)
In-Reply-To: <YHbdhT8z11rd6okI@kroah.com>
On Wednesday, April 14, 2021 2:18:13 PM CEST Greg Kroah-Hartman wrote:
> On Wed, Apr 14, 2021 at 01:52:43PM +0200, Fabio M. De Francesco wrote:
> > Removed the led_blink_hdl() function (declaration and definition).
> > Declared dummy_function() in include/rtw_mlme_ext.h and defined it in
> > core/rtw_cmd.c. Changed the second parameter of GEN_MLME_EXT_HANDLER
> > macro to make use of dummy_function().
>
> No no no.
>
> If you want to remove is function declaration and use, then do it
> properly.
>
> The code is crazy, I agree, but it should not be difficult to just
> remove this correctly instead of papering over this mess.
>
> Also note that no one actually calls this function if you look at the
> logic here.
>
> It might take some good knowledge of C to unwind this crud,
> but once done, you should be able to "prove" it's not called
>
Proving that no one actually calls it it's beyond my
current knowledge of programming with C.
Matthew W., who is for sure more experienced than I am ,
wrote that that function pointer in the array is used somewhere else.
Copied and pasted here from his message:
"Here's where the driver calls that function:
$ git grep wlancmds drivers/staging/rtl8723bs/
drivers/staging/rtl8723bs/core/rtw_cmd.c:static struct cmd_hdl wlancmds[] = {
drivers/staging/rtl8723bs/core/rtw_cmd.c: if (pcmd->cmdcode < ARRAY_SIZE(wlancmds)) {
drivers/staging/rtl8723bs/core/rtw_cmd.c: cmd_hdl = wlancmds[pcmd->cmdcode].h2cfuns;
>
> and how to
> remove it correctly.
>
I think that doing it correctly depends on the "prove" which you requested.
Doesn't it?
>
> And no, I'm not going to say how to do it, that's an exercise best left
> for the reader.
>
It sounds perfectly reasonable and I agree in full.
>
> But I will hint that this was done in the past, in
> 2014, in another driver in the tree with a codebase much like this one,
> so it shouldn't be hard to find an example of it. Only took me a few
> minutes...
>
I'm sure it took you only a few minutes. If this can be accomplished by using grep
on git log output I need some time to read this command manual again. I suppose
that the search should be made by combining "remove", "function", "drivers/staging",
and "2014". At the moment I don't know how to do that.
Notwithstanding I have said all that you read above, you can be sure that I won't give
up so easily even if it will take days :)
>
> good luck!
>
Thanks,
Fabio
>
> greg k-h
next prev parent reply other threads:[~2021-04-14 13:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 11:52 [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove useless led_blink_hdl() Fabio M. De Francesco
2021-04-14 12:00 ` Fabio Aiuto
2021-04-14 12:18 ` Greg Kroah-Hartman
2021-04-14 13:27 ` Fabio M. De Francesco [this message]
2021-04-14 13:24 ` Dan Carpenter
2021-04-14 15:36 ` Fabio M. De Francesco
-- strict thread matches above, loose matches on Subject: below --
2021-04-13 15:59 [Outreachy kernel] [PATCH] :staging: " Fabio M. De Francesco
2021-04-13 16:04 ` Julia Lawall
2021-04-13 16:19 ` Fabio M. De Francesco
2021-04-13 16:27 ` Julia Lawall
2021-04-13 16:47 ` Fabio M. De Francesco
2021-04-13 18:20 ` Dan Carpenter
2021-04-13 18:30 ` Fabio M. De Francesco
2021-04-13 18:57 ` Julia Lawall
2021-04-13 19:16 ` Fabio M. De Francesco
2021-04-13 19:25 ` Julia Lawall
2021-04-13 19:45 ` Fabio M. De Francesco
2021-04-13 19:48 ` Matthew Wilcox
2021-04-13 20:08 ` Fabio M. De Francesco
2021-04-14 5:21 ` Dan Carpenter
2021-04-14 6:33 ` Fabio M. De Francesco
2021-04-14 7:00 ` Dan Carpenter
2021-04-14 7:59 ` Fabio M. De Francesco
2021-04-14 8:06 ` Dan Carpenter
2021-04-14 7:40 ` Fabio Aiuto
2021-04-14 7:47 ` Dan Carpenter
2021-04-13 16:06 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2135425.qiX1NcrmH6@linux.local \
--to=fmdefrancesco@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).