From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: luca abeni <luca.abeni@santannapisa.it>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Juri Lelli <juri.lelli@redhat.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <Valentin.Schneider@arm.com>,
Qais Yousef <Qais.Yousef@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] sched/deadline: Fix double accounting of rq/running bw in push_dl_task()
Date: Mon, 29 Jul 2019 10:00:58 +0100 [thread overview]
Message-ID: <213a5bb3-208a-b8dc-0c80-175ceb4ae1dd@arm.com> (raw)
In-Reply-To: <20190726153002.5e49c666@sweethome>
On 7/26/19 2:30 PM, luca abeni wrote:
> Hi,
>
> On Fri, 26 Jul 2019 09:27:52 +0100
> Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
> [...]
>> @@ -2121,17 +2121,13 @@ static int push_dl_task(struct rq *rq)
>> }
>>
>> deactivate_task(rq, next_task, 0);
>> - sub_running_bw(&next_task->dl, &rq->dl);
>> - sub_rq_bw(&next_task->dl, &rq->dl);
>> set_task_cpu(next_task, later_rq->cpu);
>> - add_rq_bw(&next_task->dl, &later_rq->dl);
>>
>> /*
>> * Update the later_rq clock here, because the clock is used
>> * by the cpufreq_update_util() inside __add_running_bw().
>> */
>> update_rq_clock(later_rq);
>> - add_running_bw(&next_task->dl, &later_rq->dl);
>
> Looking at the code again and thinking a little bit more about this
> issue, I suspect a similar change is needed in pull_dl_task() too, no?
The code looks the same. Let me try to test it. I will add it in v2 then.
next prev parent reply other threads:[~2019-07-29 9:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 8:27 [PATCH 0/5] sched/deadline: Fix double accounting in push_dl_task() & some cleanups Dietmar Eggemann
2019-07-26 8:27 ` [PATCH 1/5] sched/deadline: Fix double accounting of rq/running bw in push_dl_task() Dietmar Eggemann
2019-07-26 10:11 ` luca abeni
2019-07-29 8:59 ` Dietmar Eggemann
2019-07-29 16:10 ` Peter Zijlstra
2019-07-26 13:30 ` luca abeni
2019-07-29 9:00 ` Dietmar Eggemann [this message]
2019-07-31 10:32 ` Dietmar Eggemann
2019-07-26 8:27 ` [PATCH 2/5] sched/deadline: Remove unused int flags from __dequeue_task_dl() Dietmar Eggemann
2019-07-29 16:35 ` Peter Zijlstra
2019-07-29 17:12 ` Dietmar Eggemann
2019-07-26 8:27 ` [PATCH 3/5] sched/deadline: Use __sub_running_bw() throughout dl_change_utilization() Dietmar Eggemann
2019-07-29 16:47 ` Peter Zijlstra
2019-07-29 17:21 ` Dietmar Eggemann
2019-07-26 8:27 ` [PATCH 4/5] sched/deadline: Cleanup on_dl_rq() handling Dietmar Eggemann
2019-07-26 8:37 ` Valentin Schneider
2019-07-26 8:58 ` Qais Yousef
2019-07-26 9:20 ` Juri Lelli
2019-07-26 9:32 ` Valentin Schneider
2019-07-29 16:49 ` Peter Zijlstra
2019-07-30 6:41 ` Juri Lelli
2019-07-30 8:21 ` Peter Zijlstra
2019-07-31 17:32 ` Dietmar Eggemann
2019-07-31 20:20 ` luca abeni
2019-08-01 16:01 ` Dietmar Eggemann
2019-07-26 8:27 ` [PATCH 5/5] sched/deadline: Use return value of SCHED_WARN_ON() in bw accounting Dietmar Eggemann
2019-07-26 10:18 ` luca abeni
2019-07-29 16:54 ` Peter Zijlstra
2019-07-29 16:59 ` Dietmar Eggemann
2019-07-30 8:23 ` Peter Zijlstra
2019-07-30 16:08 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=213a5bb3-208a-b8dc-0c80-175ceb4ae1dd@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=Qais.Yousef@arm.com \
--cc=Valentin.Schneider@arm.com \
--cc=bristot@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).