From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Alex Williamson <alex.williamson@redhat.com>,
Wen Xiong <wenxiong@linux.vnet.ibm.com>,
Gavin Shan <gwshan@linux.vnet.ibm.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio/pci: make MSI handling optional
Date: Mon, 13 Oct 2014 13:02:54 +0200 [thread overview]
Message-ID: <2147756.6NWYQ577Sd@wuerfel> (raw)
In-Reply-To: <1413190208.4202.34.camel@ul30vt.home>
On Monday 13 October 2014 02:50:08 Alex Williamson wrote:
>
> Why wouldn't we handle this with stubs for `get_cached_msi_msg' and
> `write_msi_msg'? We're really not talking about much code that might
> get removed by the compiler with this static branch and and it seems
> like a rather non-standard mechanism. The count of MSI/X IRQs
> advertised to the user should be zero without CONFIG_MSI and later range
> checks would prevent calls to
> these functions for invalid indexes, so it's a bit of a random test in
> the code flow. Thanks,
>
That's fine with me too.
Arnd
next prev parent reply other threads:[~2014-10-13 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 8:40 [PATCH] vfio/pci: make MSI handling optional Arnd Bergmann
2014-10-13 8:50 ` Alex Williamson
2014-10-13 11:02 ` Arnd Bergmann [this message]
2017-02-14 21:53 ` [PATCH] genirq/msi: add stubs for get_cached_msi_msg/pci_write_msi_msg Arnd Bergmann
2017-02-16 14:34 ` [tip:irq/core] genirq/msi: Add " tip-bot for Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2147756.6NWYQ577Sd@wuerfel \
--to=arnd@arndb.de \
--cc=alex.williamson@redhat.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wenxiong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).