linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: Zhang Rui <rui.zhang@intel.com>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Quanxian Wang <quanxian.wang@intel.com>
Subject: [PATCH v1 0/4] thermal: core/ACPI: Fix processor cooling device regression
Date: Fri, 03 Mar 2023 20:18:30 +0100	[thread overview]
Message-ID: <2148907.irdbgypaU6@kreacher> (raw)

Hi All,

As reported by Rui in this thread:

Link: https://lore.kernel.org/linux-pm/53ec1f06f61c984100868926f282647e57ecfb2d.camel@intel.com/

some recent changes in the thermal core cause the CPU cooling devices
registered by the ACPI processor driver to become unusable in some cases
and somewhat crippled in general.

The problem is that the ACPI processor driver changes its ->get_max_state()
callback return value depending on whether or not cpufreq is available and
there is a cpufreq policy for a given CPU.  However, the thermal core has
always assumed that the return value of that callback will not change, which
in fact is relied on by the cooling device statistics code.  In particular,
when the ->get_max_state() grows, the memory buffer allocated for storing the
statistics will be too small and corruption may ensue as a result.

For this reason, the issue needs to be addressed in the ACPI processor driver
and not in the thermal core, but the core needs to help somewhat too.  Namely,
it needs to provide a helper allowing an interested driver to update the
max_state value for an already registered cooling device in certain situations
which will also cause the statistics to be rebuilt.

This series implements the above and for details please refer to the individual
patch chagelogs.

Please also note that it has only been lightly tested, so more testing and of
course review of it is welcome.

Thanks!




             reply	other threads:[~2023-03-03 19:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 19:18 Rafael J. Wysocki [this message]
2023-03-03 19:19 ` [PATCH v1 1/4] ACPI: processor: Reorder acpi_processor_driver_init() Rafael J. Wysocki
2023-03-07 16:51   ` Zhang, Rui
2023-03-10 18:31     ` Rafael J. Wysocki
2023-03-12 16:08   ` Zhang, Rui
2023-03-13 13:48     ` Rafael J. Wysocki
2023-03-13 14:54       ` Zhang, Rui
2023-03-13 14:58         ` Rafael J. Wysocki
2023-03-03 19:21 ` [PATCH v1 2/4] thermal: core: Introduce thermal_cooling_device_present() Rafael J. Wysocki
2023-03-03 19:23 ` [PATCH v1 3/4] thermal: core: Introduce thermal_cooling_device_update() Rafael J. Wysocki
2023-03-07 16:40   ` Zhang, Rui
2023-03-10 18:25     ` Rafael J. Wysocki
2023-03-27 20:57   ` Imre Deak
2023-03-28 15:35     ` Rafael J. Wysocki
2023-03-03 19:23 ` [PATCH v1 4/4] ACPI: processor: thermal: Update CPU cooling devices on cpufreq policy changes Rafael J. Wysocki
2023-03-07 16:43   ` Zhang, Rui
2023-03-10 18:29     ` Rafael J. Wysocki
2023-03-12 14:44       ` Zhang, Rui
2023-03-13 13:50         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2148907.irdbgypaU6@kreacher \
    --to=rjw@rjwysocki.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=quanxian.wang@intel.com \
    --cc=rui.zhang@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).