From: Dmitry Osipenko <firstname.lastname@example.org> To: "Michał Mirosław" <email@example.com> Cc: firstname.lastname@example.org, Dmitry Torokhov <email@example.com>, firstname.lastname@example.org Subject: Re: [PATCH 3/6] input: elants: support common touchscreen DT properties Date: Wed, 11 Dec 2019 18:26:02 +0300 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20191211032813.GA17731@qmqm.qmqm.pl> 11.12.2019 06:28, Michał Mirosław пишет: > On Tue, Dec 10, 2019 at 06:21:02PM +0300, Dmitry Osipenko wrote: >> 10.12.2019 05:38, Michał Mirosław пишет: >>> On Tue, Dec 10, 2019 at 04:03:18AM +0300, Dmitry Osipenko wrote: >>>> 10.12.2019 03:19, Michał Mirosław пишет: >>>>> Support common DT properties like axis inversions to complement >>>>> information obtained from device's firmware.a >>> [...] >>>>> @@ -1251,13 +1250,15 @@ static int elants_i2c_probe(struct i2c_client *client, >>>>> ts->input->name = "Elan Touchscreen"; >>>>> ts->input->id.bustype = BUS_I2C; >>>>> >>>>> + touchscreen_parse_properties(ts->input, true, &ts->prop); >>>> >>>> Shouldn't this function be invoked after setting the max x/y sizes with >>>> the hardware values? That's what all other drivers do and then you won't >>>> need to set the ts->prop.max_x/y above in the code. >>> >>> This is done later in the series - this patch only adds axis inversion >>> support and ignores DT-provided sizes. >> >> What is the reason of splitting it into two patches? >> >> Perhaps I'm still missing something, but why something a bit more simple >> like this wouldn't yield exactly the same result: > [...] > > Originally I thought to skip probing the hardware when all info is > already provided in devicetree. This didn't happen, though. I'll take > your patch then, with a slight adjustment in "prop"'s position... And > the rest of them, so as to not duplicate the work. :-) Okay
next prev parent reply other threads:[~2019-12-11 15:26 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-10 0:19 [PATCH 0/6] input: elants: Support Asus TF300T touchscreen Michał Mirosław 2019-12-10 0:19 ` [PATCH 2/6] input: elants: support old touch report format Michał Mirosław 2019-12-10 0:19 ` [PATCH 3/6] input: elants: support common touchscreen DT properties Michał Mirosław 2019-12-10 1:03 ` Dmitry Osipenko 2019-12-10 1:07 ` Dmitry Osipenko 2019-12-10 2:38 ` Michał Mirosław 2019-12-10 15:21 ` Dmitry Osipenko 2019-12-11 3:28 ` Michał Mirosław 2019-12-11 15:26 ` Dmitry Osipenko [this message] 2019-12-10 0:19 ` [PATCH 1/6] input: elants: document some registers and values Michał Mirosław 2019-12-10 0:19 ` [PATCH 6/6] input: elants: read touchscreen size for EKTF3624 Michał Mirosław 2019-12-10 1:23 ` Dmitry Osipenko 2019-12-10 1:48 ` Dmitry Osipenko 2019-12-10 18:32 ` kbuild test robot 2019-12-10 0:19 ` [PATCH 5/6] input: elants: refactor elants_i2c_execute_command() Michał Mirosław 2019-12-10 1:34 ` Dmitry Osipenko 2019-12-10 0:19 ` [PATCH 4/6] input: elants: detect max_x/y from hardware Michał Mirosław 2019-12-10 0:59 ` [PATCH 0/6] input: elants: Support Asus TF300T touchscreen Dmitry Osipenko 2019-12-10 15:26 ` Dmitry Osipenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 3/6] input: elants: support common touchscreen DT properties' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).