From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751919AbdLCSVO (ORCPT ); Sun, 3 Dec 2017 13:21:14 -0500 Received: from mout.web.de ([217.72.192.78]:63607 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751143AbdLCSVK (ORCPT ); Sun, 3 Dec 2017 13:21:10 -0500 Subject: Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions To: Joe Perches , linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org Cc: "Andrew F. Davis" , Arvind Yadav , Bartlomiej Zolnierkiewicz , LKML , kernel-janitors@vger.kernel.org, Ladislav Michl , Tomi Valkeinen References: <1511809633.32426.70.camel@perches.com> <1511833514.32426.86.camel@perches.com> <7e7e64cf-dbe5-614a-f1e5-29d7b6cf9297@users.sourceforge.net> <1511856244.19952.14.camel@perches.com> From: SF Markus Elfring Message-ID: <21554e23-e714-3f6f-cd70-4c277823bab3@users.sourceforge.net> Date: Sun, 3 Dec 2017 19:20:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1511856244.19952.14.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:thtcuAeZEdo0OfT+cPzc9mb6On69IzPwkD7qEDY78ZG8Fi5a13u hmC/5nXcZRFcbZ7p/w+umAMYBjcBx5EVXTg8mkWJg7+5sNOMiNU8bNAhWiGMALIWkbQXKb8 ltHqAH9ixNDYur598reyEOSHJ7bavkkJg0lFfMb/MPtpxg3HcwiUvpCvJXpqhag6QVyPQD/ kjSKlgKUA6vVjg7lFA/4A== X-UI-Out-Filterresults: notjunk:1;V01:K0:EBfsTc2rAhU=:hcU2frN957sC0txW9xqCO9 89fUIeG5laIFcu6kWoh2uoakwoEC8Z4A4xouOrvAswisdtNmnhkbqx0bFXnosUdjx8mirkKob F5rOvdMoHeETNkloyq77p6YiL+zQfz9sfbVkhdan5J219N6ntO3a8wugsOT/dcU1+Bf4UuslV Md0Dhm9UdjlKtUVU5mkX1WT+TfdB1GPdml4N7L1PRnON/FwWJ0biCUOgLw6pLnbGlbPjJBGJh 7+e+44sXcvaQILnMouMmNw7GiMpo0shX8JixextnF5mgcz3lh6BxoaaMy5elUFk3+kUhz15IQ 7akQaUENUT+A9KmeV4Tmo+1QeJ9fUdEC+/swyRpcVPcoiyqylFoVW11oQAIHcj9ekuC+PPjxY uVHYFMUWb8Y4fliBsnlGhuCSn/CqB0JNrIHnuqHfGOQlQd0z9rqlAxNyugUGt6gmdEJezbPVG NiHPW0mYPAMpJrReZyy1mImr4g8RsGgdWruqjY6W6jxGYWSRCM4aQBAhp2JourS1eoAxjsCuw 83qv8kiBcVUHe92AIgJUnsgTZ9FOVpdiF0i87X9Zn+B1zJUrMLT92SItfyz5H7yp3AE3RWQVM iLwhoItxDFc0Lochvi7aJXfXrK05FG4ihxzhfP8QldhGo+oBR1K7B6f1P8CN0GnGq0ZtXFMKc 4sau85+XLgBln20yo47fyBpOTAjkNZOiDd/wic7wZnUUKKG7GIIWVRTAqDZdRtGXDEAY91DkN mfEnBX0vmYSLAYgIJJV01ajoiS81qnBNZvsP4Gwajwc93Elfr8PoAfQnNZeQVJqPRewFzuPRR qgidPYSU7p/Kt5lMFX7FAdkjkMyMebx2NOzqjGELdwlurxMtpY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > How many times have I told you to include the reason for your patches > in your proposed commit message? Will it be useful to look again at the involved circumstances? > Too often. Did I answer any concerns partly? > Many people do not know that a generic kmalloc does a dump_stack() on OOM. Do you see a need to represent such information better? Is it expected that the function “devm_kzalloc” has got a similar property? > That information should be part of the commit message. How do you think about to share it also from any reference documentation in a clearer way? Do we stumble on a target conflict in this case? I am generally trying to improve the software situation to some degree. I prefer then to work with safe information sources. Unfortunately, I might have not reached a desired confidence level here for a more detailed commit message. I assume that software development efforts could increase in significant ways if something should be improved further in a direction I hope. But this could mean that time frames will grow for corresponding clarifications. * Does such a situation block progress on the deletion of other remaining questionable error messages? * Would you like to increase the software development attention anyhow? By the way: It seems that my update suggestion for the directory “omapfb/dss” could be superseded by the patch “omapfb: dss: Do not duplicate features data” from Ladislav Michl. https://patchwork.kernel.org/patch/10082027/ https://lkml.kernel.org/r/<20171129123308.GA26578@lenoch> Regards, Markus