From: David Howells <dhowells@redhat.com>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: dhowells@redhat.com, Guenter Roeck <linux@roeck-us.net>,
Andrew Morton <akpm@linux-foundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] frv: Declare jiffies to be located in the .data section
Date: Wed, 24 May 2017 13:53:54 +0100 [thread overview]
Message-ID: <21627.1495630434@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170516221333.177280-1-mka@chromium.org>
Matthias Kaehlcke <mka@chromium.org> wrote:
> Commit 7c30f352c852 ("jiffies.h: declare jiffies and jiffies_64 with
> ____cacheline_aligned_in_smp") removed a section specification from the
> jiffies declaration that caused conflicts on some platforms. Unfortunately
> this change broke the build for frv:
>
> kernel/built-in.o: In function `__do_softirq':
> (.text+0x6460): relocation truncated to fit: R_FRV_GPREL12 against symbol
> `jiffies' defined in *ABS* section in .tmp_vmlinux1
> kernel/built-in.o: In function `__do_softirq':
> (.text+0x6574): relocation truncated to fit: R_FRV_GPREL12 against symbol
> `jiffies' defined in *ABS* section in .tmp_vmlinux1
> kernel/built-in.o: In function `pwq_activate_delayed_work':
> workqueue.c:(.text+0x15b9c): relocation truncated to fit: R_FRV_GPREL12 against
> symbol `jiffies' defined in *ABS* section in .tmp_vmlinux1
> ...
>
> Add __jiffy_arch_data to the declaration of jiffies and use it on frv to
> include the section specification. For all other platforms __jiffy_arch_data
> (currently) has no effect.
>
> Fixes: 7c30f352c852 ("jiffies.h: declare jiffies and jiffies_64 with
> ____cacheline_aligned_in_smp")
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: David Howells <dhowells@redhat.com>
prev parent reply other threads:[~2017-05-24 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 22:13 [PATCH] frv: Declare jiffies to be located in the .data section Matthias Kaehlcke
2017-05-16 22:28 ` Guenter Roeck
2017-05-24 12:53 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21627.1495630434@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mka@chromium.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).