From: Lukasz Luba <lukasz.luba@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Eduardo Valentin <edubezval@gmail.com>,
Javi Merino <javi.merino@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
linaro-kernel@lists.linaro.org,
Amit Daniel Kachhap <amit.kachhap@gmail.com>,
Rafael Wysocki <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH V2 00/17] thermal: cpu_cooling: improve interaction with cpufreq core
Date: Mon, 24 Apr 2017 11:43:11 +0100 [thread overview]
Message-ID: <21699d92-64f1-1819-0a30-4f38cb786bf6@arm.com> (raw)
In-Reply-To: <20170419052206.GA5436@vireshk-i7>
Hi Viresh,
I was out of office.
I run your v3 (from git) with some basic tests.
IPA does not work, at least v3 does not crash the kernel.
I didn't have time to go through the patches to narrow down
the problem.
If you would like to run some basic test,
you can find it here [1].
I am happy to check v4 when it is ready.
Best regards,
Lukasz
[1]
https://github.com/ARM-software/lisa/blob/master/ipynb/thermal/ThermalSensorCharacterisation.ipynb
On 19/04/17 06:22, Viresh Kumar wrote:
> On 18-04-17, 15:40, Lukasz Luba wrote:
>> Hi Viresh,
>>
>> I have checkout your branch at newest commit:
>> 908063832c268f8add94
>> I have built it and run it on my Juno r2.
>> I have some python tests for IPA and I run one of them.
>>
>> I seen a few issues so I have created a patch just
>> to be able to run IPA.
>> My next email will have the patch so you can see the changes.
>>
>> IPA does not work with this patch set.
>> I have tested two source codes from your repo:
>> 1. your change 908063832c268f8add94
>> 2. your base 8f506e0faf4e2a4a0bde9f9b1
>>
>> In case 1. IPA does not work - temperature rises to 83degC
>> in case 2. works - temperature is limited to 65degC.
>
> Yeah, there were some cases power specific cases that weren't covered in my
> tests and thanks a lot for testing it out. I have pushed my branch again and it
> has all your fixes (a bit refined) in it.
>
>> On Monday I can allocate more time for it.
>
> My branch should just work now. Please see if you can allocate 10-15 min today
> to give it a try, so that we can get it in earlier. I will send a V3 today and
> your Tested-by would be very much appreciated.
>
> Thanks Lukasz.
>
next prev parent reply other threads:[~2017-04-24 10:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 6:01 [PATCH V2 00/17] thermal: cpu_cooling: improve interaction with cpufreq core Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 01/17] thermal: cpu_cooling: Avoid accessing potentially freed structures Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 02/17] thermal: cpu_cooling: rearrange globals Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 03/17] thermal: cpu_cooling: Name cpufreq cooling devices as cpufreq_cdev Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 04/17] thermal: cpu_cooling: replace cool_dev with cdev Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 05/17] thermal: cpu_cooling: remove cpufreq_cooling_get_level() Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 06/17] thermal: cpu_cooling: get rid of a variable in cpufreq_set_cur_state() Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 07/17] thermal: cpu_cooling: use cpufreq_policy to register cooling device Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 08/17] cpufreq: create cpufreq_table_count_valid_entries() Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 09/17] thermal: cpu_cooling: store cpufreq policy Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 10/17] thermal: cpu_cooling: OPPs are registered for all CPUs Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 11/17] thermal: cpu_cooling: get rid of 'allowed_cpus' Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 12/17] thermal: cpu_cooling: merge frequency and power tables Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 13/17] thermal: cpu_cooling: create structure for idle time stats Viresh Kumar
2017-04-17 6:01 ` [PATCH V2 14/17] thermal: cpu_cooling: get_level() can't fail Viresh Kumar
2017-04-17 6:02 ` [PATCH V2 15/17] thermal: cpu_cooling: don't store cpu_dev in cpufreq_cdev Viresh Kumar
2017-04-17 6:02 ` [PATCH V2 16/17] thermal: cpu_cooling: 'freq' can't be zero in cpufreq_state2power() Viresh Kumar
2017-04-17 6:02 ` [PATCH V2 17/17] thermal: cpu_cooling: Rearrange struct cpufreq_cooling_device Viresh Kumar
2017-04-17 17:34 ` [PATCH V2 00/17] thermal: cpu_cooling: improve interaction with cpufreq core Eduardo Valentin
2017-04-17 17:51 ` Eduardo Valentin
2017-04-18 7:23 ` Lukasz Luba
2017-04-18 10:38 ` Viresh Kumar
2017-04-18 14:40 ` Lukasz Luba
2017-04-18 14:51 ` [PATCH] thermal: fix cpu cooling initialization Lukasz Luba
2017-04-19 5:22 ` [PATCH V2 00/17] thermal: cpu_cooling: improve interaction with cpufreq core Viresh Kumar
2017-04-24 10:43 ` Lukasz Luba [this message]
2017-04-24 10:44 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21699d92-64f1-1819-0a30-4f38cb786bf6@arm.com \
--to=lukasz.luba@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=edubezval@gmail.com \
--cc=javi.merino@kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).