From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D812C35659 for ; Fri, 21 Feb 2020 17:48:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 161BA206E2 for ; Fri, 21 Feb 2020 17:48:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dIe+RgCz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728594AbgBURsE (ORCPT ); Fri, 21 Feb 2020 12:48:04 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:29418 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727655AbgBURsD (ORCPT ); Fri, 21 Feb 2020 12:48:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582307282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RrMvZJoVJBWqnzqNr9KyLlzqZ46CEJlOdAIqg//g6XU=; b=dIe+RgCzUCc+j7/6priU5r1awTTJQpfHKW2bI2qO6EjtMl47Qz3hE64Uw/VgBVyGkzxC42 2zU1dBq0ERQMUFnIFWtvhrgWHJRJfV3GxpUdsIJ1MhKCGjYxobTul+jQSvkfmgaPas+dOm /FAGwnA7Pd7J02ViLqFWSUZZGWvZkEY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-365-HnvsnQK8MFOUa1iSTmOF2Q-1; Fri, 21 Feb 2020 12:47:56 -0500 X-MC-Unique: HnvsnQK8MFOUa1iSTmOF2Q-1 Received: by mail-wr1-f70.google.com with SMTP id o6so1332880wrp.8 for ; Fri, 21 Feb 2020 09:47:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RrMvZJoVJBWqnzqNr9KyLlzqZ46CEJlOdAIqg//g6XU=; b=F+w8aoOhRU2eJ19HOBrQ125PdslAb2zEVy9aDd4igyQin8IaB+6GXbrf3ase6+Aca7 92zMh2YoLqkMAPQaxf/MOHi7gTndLrRD/ywm/3u8yLAvdtUidhbo6DKdqoWhax3+YXTR aTOEc0FZN7ZL+DUSvexCfF5Q8JfczwIOZI2N7+r3EHjsYOWt/eeqVSzKsnLiWviN1K00 uNoSHdS3g8OJNrwzds1YNQh1JhlYu9D7+5W2IDQSPU9an7Xpvln4Oi0MXfE00AKc1PkA i77PNJILEqlta1U01UtyYEs38KiJGxprx7FNFiw+0EIOASOGUsqtcD3U+KNK4x8LUTqt 33rg== X-Gm-Message-State: APjAAAXm6/HJxN81IEuKmn4Xn9mj/X7zE+3wDgqPF4nuH5nox5B9TV4M d8JCpU0zWnA0xRCfg+7fGB+CWb3IRgSlddOpQEJEpVZA0UGPLy+7cNyJ4ILAhInD8kH7FV5jtAj ZroXAqdwSELzHzD27CkDGJqlH X-Received: by 2002:adf:e68d:: with SMTP id r13mr49225905wrm.349.1582307275646; Fri, 21 Feb 2020 09:47:55 -0800 (PST) X-Google-Smtp-Source: APXvYqzI29TQnMTxhegOPTR5SZPy7HDTeZP8mdmwqeW3b3wvRv6t/VcN7GX1ZnOVCmuZ9M9Iv9A8Vg== X-Received: by 2002:adf:e68d:: with SMTP id r13mr49225876wrm.349.1582307275388; Fri, 21 Feb 2020 09:47:55 -0800 (PST) Received: from [192.168.178.40] ([151.20.135.128]) by smtp.gmail.com with ESMTPSA id x6sm4531952wmi.44.2020.02.21.09.47.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Feb 2020 09:47:54 -0800 (PST) Subject: Re: [PATCH v6 17/22] KVM: Terminate memslot walks via used_slots To: Sean Christopherson Cc: Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Christoffer Dall , Peter Xu , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20200218210736.16432-1-sean.j.christopherson@intel.com> <20200218210736.16432-18-sean.j.christopherson@intel.com> From: Paolo Bonzini Message-ID: <216d647a-e598-d5d6-e20f-9c44c9ca157f@redhat.com> Date: Fri, 21 Feb 2020 18:47:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20200218210736.16432-18-sean.j.christopherson@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/02/20 22:07, Sean Christopherson wrote: > tmp = id_to_memslot(__kvm_memslots(kvm, as_id), id); > - old = *tmp; > - tmp = NULL; > + if (tmp) { > + old = *tmp; > + tmp = NULL; > + } else { > + memset(&old, 0, sizeof(old)); > + old.id = id; > + } > So much for my previous brilliant suggestion. :) Paolo