From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FFCBC4338F for ; Sun, 22 Aug 2021 20:25:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C6636127B for ; Sun, 22 Aug 2021 20:25:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232923AbhHVUZu (ORCPT ); Sun, 22 Aug 2021 16:25:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229654AbhHVUZt (ORCPT ); Sun, 22 Aug 2021 16:25:49 -0400 Received: from mail-oo1-xc29.google.com (mail-oo1-xc29.google.com [IPv6:2607:f8b0:4864:20::c29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16FEBC061575 for ; Sun, 22 Aug 2021 13:25:08 -0700 (PDT) Received: by mail-oo1-xc29.google.com with SMTP id h7-20020a4ab4470000b0290263c143bcb2so4778395ooo.7 for ; Sun, 22 Aug 2021 13:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bmqpliNkb/094MxV6QHJZFPABtXQSbh+VW+dL1e7K80=; b=iEXXicu0IkA+WDA8cnmhaZ/9F4aueoVx4xzKHAUvUsEqe+V5Q6TO0S+zqkO+Vu1RIW WZUvT4Ufh3nvOM/QRrB/hDzDTOVI794tsO/VOLjxxp+QFTpNc1rq00koFhXzXXNJ/L5c 4pxhr7y4sJDkZ40JgZMyt2Fqk1uooFx8izkEWA1dzHkGa9naeH8jT0MTLPCZ30jIoKap IEBJCQwWZBO9nt17zJP20MZ1PsCi4aUt9KXPBnVbXnjrjWr1yEcCYVjn3YRiJhiTQOpo elnb8OQP4xl8JcBFIU7YNMEYfYuLeKZ0u/UF4KffYu5qImwloUO69BY+cLHYIR514dHT V4Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bmqpliNkb/094MxV6QHJZFPABtXQSbh+VW+dL1e7K80=; b=HqdB6e8FQhS2CHPXoO0xNwHlJEm305uxZkkuClcdi8T92zs8J3YIyazS4dCkKK3hrn tdy1mqWwVHEs8soBwGNtYlKnJxdc2dt+h3lo6BdkrPMrffv2zjNxY3A8xxgP8g9KXKrn R4nI26mvfsjI95zRzIEWKkivZmfx8xf7KuxOEwpxFfGVjZmduqn0B7ZhcmUDMAH76fpF fdU//0CJWoXVLDSFi7+xb2AgARw0uq1qW5DEmu1mwHf1A3akE8Tg1mFyM5G6OU3mDZBX rGI/nzr/x2sHoYwyZc1pU5YHanmGd71s83ZKnm+8te9iD4PETEEj96l5IGdfRtrD7891 gf3w== X-Gm-Message-State: AOAM5330ir24ztM0NcpUtboRMQWtvboqYswSKYtN8F/I16i3/ATlON0t AeL9V6x2DyqDrNHX9j2l1AYhU1gFpOg= X-Google-Smtp-Source: ABdhPJymDottKPNee2tDP8BQlzMP4zQzssgEtS0WYrLveWx1JxJxi5uP3rDx3ceMDGAjP0blYXWSQA== X-Received: by 2002:a4a:9f53:: with SMTP id d19mr9480242ool.8.1629663907073; Sun, 22 Aug 2021 13:25:07 -0700 (PDT) Received: from 2603-8090-2005-39b3-0000-0000-0000-1023.res6.spectrum.com (2603-8090-2005-39b3-0000-0000-0000-1023.res6.spectrum.com. [2603:8090:2005:39b3::1023]) by smtp.gmail.com with ESMTPSA id a6sm3235834oto.36.2021.08.22.13.25.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Aug 2021 13:25:06 -0700 (PDT) Sender: Larry Finger Subject: Re: [PATCH v3 5/5] staging: r8188eu: incorrect type in assignment To: Aakash Hemadri , Greg Kroah-Hartman , Phillip Potter Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <876b83dad76a6f561879da0db1fbb25b251374d4.1629562355.git.aakashhemadri123@gmail.com> From: Larry Finger Message-ID: <2188755e-33b1-bbe9-6f9b-e184830612ba@lwfinger.net> Date: Sun, 22 Aug 2021 15:25:05 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <876b83dad76a6f561879da0db1fbb25b251374d4.1629562355.git.aakashhemadri123@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/21/21 11:18 AM, Aakash Hemadri wrote: > Fix sparse warning: >> rtw_br_ext.c:516:57: warning: incorrect type in assignment > (different base types) >> rtw_br_ext.c:516:57: expected unsigned short >> rtw_br_ext.c:516:57: got restricted __be16 [usertype] > > *pMagic holds __be16 change it's type to __be16 > > Signed-off-by: Aakash Hemadri > --- > drivers/staging/r8188eu/core/rtw_br_ext.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c > index 83a4594a4214..14cf13516d34 100644 > --- a/drivers/staging/r8188eu/core/rtw_br_ext.c > +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c > @@ -474,7 +474,7 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method) > /* Handle PPPoE frame */ > /*---------------------------------------------------*/ > struct pppoe_hdr *ph = (struct pppoe_hdr *)(skb->data + ETH_HLEN); > - unsigned short *pMagic; > + __be16 *pMagic; > > switch (method) { > case NAT25_CHECK: > @@ -512,7 +512,7 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method) > tag->tag_len = htons(MAGIC_CODE_LEN+RTL_RELAY_TAG_LEN+old_tag_len); > > /* insert the magic_code+client mac in relay tag */ > - pMagic = (unsigned short *)tag->tag_data; > + pMagic = (__be16 *)tag->tag_data; > *pMagic = htons(MAGIC_CODE); > memcpy(tag->tag_data+MAGIC_CODE_LEN, skb->data+ETH_ALEN, ETH_ALEN); > > For all 5 patches, Ack by Larry Finger Thanks, Larry