From: Randy Dunlap <rdunlap@infradead.org>
To: XiaoLi Feng <xifeng@redhat.com>,
linux-kernel@vger.kernel.org, ira.weiny@intel.com,
darrick.wong@oracle.com
Cc: Xiaoli Feng <fengxiaoli0714@gmail.com>
Subject: Re: [PATCH] fs/stat: set attributes_mask for STATX_ATTR_DAX
Date: Fri, 20 Nov 2020 16:58:09 -0800 [thread overview]
Message-ID: <21890103-fce2-bb50-7fc2-6c6d509b982f@infradead.org> (raw)
In-Reply-To: <20201121003331.21342-1-xifeng@redhat.com>
Hi,
I don't know this code, but:
On 11/20/20 4:33 PM, XiaoLi Feng wrote:
> From: Xiaoli Feng <fengxiaoli0714@gmail.com>
>
> keep attributes and attributes_mask are consistent for
> STATX_ATTR_DAX.
> ---
> fs/stat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/stat.c b/fs/stat.c
> index dacecdda2e79..914a61d256b0 100644
> --- a/fs/stat.c
> +++ b/fs/stat.c
> @@ -82,7 +82,7 @@ int vfs_getattr_nosec(const struct path *path, struct kstat *stat,
>
> if (IS_DAX(inode))
> stat->attributes |= STATX_ATTR_DAX;
> -
> + stat->attributes_mask |= STATX_ATTR_DAX;
Why shouldn't that be:
if (IS_DAX(inode))
stat->attributes_mask |= STATX_ATTR_DAX;
or combine them, like this:
if (IS_DAX(inode)) {
stat->attributes |= STATX_ATTR_DAX;
stat->attributes_mask |= STATX_ATTR_DAX;
}
and no need to delete that blank line.
> if (inode->i_op->getattr)
> return inode->i_op->getattr(path, stat, request_mask,
> query_flags);
>
thanks.
--
~Randy
next prev parent reply other threads:[~2020-11-21 0:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 0:33 [PATCH] fs/stat: set attributes_mask for STATX_ATTR_DAX XiaoLi Feng
2020-11-21 0:58 ` Randy Dunlap [this message]
2020-11-21 2:03 ` Darrick J. Wong
2020-11-22 15:57 ` Xiaoli Feng
2020-11-23 21:37 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21890103-fce2-bb50-7fc2-6c6d509b982f@infradead.org \
--to=rdunlap@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=fengxiaoli0714@gmail.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xifeng@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).