From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Lu, Brent" <brent.lu@intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: "Rojewski, Cezary" <cezary.rojewski@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
"Subhransu S . Prusty" <subhransu.s.prusty@intel.com>,
Richard Fontana <rfontana@redhat.com>,
Tzung-Bi Shih <tzungbi@google.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Thomas Gleixner <tglx@linutronix.de>,
"M, Naveen" <naveen.m@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: eve: implement set_bias_level function for rt5514
Date: Fri, 25 Oct 2019 09:48:24 -0500 [thread overview]
Message-ID: <219281e5-d685-d584-0d22-5dcf3ca2bec2@linux.intel.com> (raw)
In-Reply-To: <CF33C36214C39B4496568E5578BE70C740320822@PGSMSX108.gar.corp.intel.com>
On 10/25/19 9:43 AM, Lu, Brent wrote:
>> On 10/25/19 4:11 AM, Brent Lu wrote:
>>> The first DMIC capture always fail (zero sequence data from PCM port)
>>> after using DSP hotwording function (i.e. Google assistant).
>>
>> Can you clarify where the DSP hotwording is done? Intel DSP or rt5514?
>>
>> Turning on the MCLK with the BIAS info might force the Intel DSP to remain
>> on, which would impact power consumption if it was supposed to remain off.
>>
>
> Hi Pierre,
>
> It's done in rt5514's DSP and the interface is SPI instead of I2S for the voice wake
> up function.
>
> There is a driver rt5514-spi.c which provides platform driver and DAI. User space
> application first uses the mixer to turn on the voice wake up function:
>
> amixer -c0 cset name='DSP Voice Wake Up' on
>
> Then open and read data from the PCM port which goes to the SPI platform and
> dai code. Finally it uses same mixer to turn off the function and return to normal
> codec mode. The DMIC recording (from I2S) and the voice wake on function should
> be mutually exclusive according to the driver design.
>
> In the codec driver rt5514.c there is a rt5514_set_bias_level function. It's expected to
> turn on/off mclk here according to Realtek people's say but our ssp clock requires set
> rate function to be called in advance so I implement the code in machine driver.
Can you clarify if the rt5514 needs the MCLK while it's doing the
hotword detection?
My point is really that this patch uses a card-level BIAS indication,
and I'd like to make sure this does not interfere with the audio DSP
being in D3 state.
next prev parent reply other threads:[~2019-10-25 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 9:11 [PATCH] ASoC: eve: implement set_bias_level function for rt5514 Brent Lu
2019-10-25 14:05 ` [alsa-devel] " Pierre-Louis Bossart
2019-10-25 14:43 ` Lu, Brent
2019-10-25 14:48 ` Pierre-Louis Bossart [this message]
2019-10-25 16:14 ` Lu, Brent
2019-10-25 16:57 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=219281e5-d685-d584-0d22-5dcf3ca2bec2@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.m@intel.com \
--cc=perex@perex.cz \
--cc=rfontana@redhat.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).