From: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
<bjorn.andersson@linaro.org>, <ohad@wizery.com>,
<mcoquelin.stm32@gmail.com>, <alexandre.torgue@st.com>
Cc: <loic.pallardy@st.com>, <linux-remoteproc@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 00/12] remoteproc: stm32: Add support for synchronising with M4
Date: Wed, 29 Apr 2020 17:08:32 +0200 [thread overview]
Message-ID: <219771d3-b0a5-0ec7-7f20-d2055bcb0217@st.com> (raw)
In-Reply-To: <20200424202505.29562-1-mathieu.poirier@linaro.org>
Hi Mathieu,
On 4/24/20 10:24 PM, Mathieu Poirier wrote:
> This patchset needs to be applied on top of this one [1].
>
> It refactors the STM32 platform code in order to introduce support for
> synchronising with the M4 remote processor that would have been started by
> the boot loader or another entity.
>
> It carries the same functionatlity as the previeous revision but account
> for changes in the remoteproc core to support synchronisation scenarios.
> Some RB tags have been removed when the content of the patch has strayed
> too far from the original version. See patch 3, 8, 9 and 12 for more
> details.
I reviewed the series, and made some tests on my side.
FYI, I do not answer to patches when tagged "Reviewed-by: Loic Pallardy"
and with no extra remark. So consider them as Reviewed-by me but not
necessary to add the tag in commit, Reviewed-by: loic in commit is sufficient.
Concerning tests, it works find except the crash recovery from a sync start.
But i suppose that you know the limitation, waiting Loic patches[1] update :)
[1]: https://lkml.org/lkml/2020/3/11/403
Thanks a lot for your work!
Arnaud
>
> Tested on ST's mp157c board.
>
> Thanks,
> Mathieu
>
> [1]. https://patchwork.kernel.org/project/linux-remoteproc/list/?series=277049
> [2]. https://patchwork.kernel.org/project/linux-remoteproc/list/?series=239877
>
> Mathieu Poirier (12):
> remoteproc: stm32: Decouple rproc from memory translation
> remoteproc: stm32: Request IRQ with platform device
> remoteproc: stm32: Decouple rproc from DT parsing
> remoteproc: stm32: Remove memory translation from DT parsing
> remoteproc: stm32: Parse syscon that will manage M4 synchronisation
> remoteproc: stm32: Get coprocessor state
> remoteproc: stm32: Get loaded resource table for synchronisation
> remoteproc: stm32: Introduce new start ops for synchronisation
> remoteproc: stm32: Update M4 state in stm32_rproc_stop()
> remoteproc: stm32: Introduce new parse fw ops for synchronisation
> remoteproc: stm32: Introduce new loaded rsc ops for synchronisation
> remoteproc: stm32: Set synchronisation state machine if needed
>
> drivers/remoteproc/stm32_rproc.c | 262 ++++++++++++++++++++++++++++---
> 1 file changed, 244 insertions(+), 18 deletions(-)
>
next prev parent reply other threads:[~2020-04-29 15:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 20:24 [PATCH v2 00/12] remoteproc: stm32: Add support for synchronising with M4 Mathieu Poirier
2020-04-24 20:24 ` [PATCH v2 01/12] remoteproc: stm32: Decouple rproc from memory translation Mathieu Poirier
2020-05-14 4:57 ` Bjorn Andersson
2020-04-24 20:24 ` [PATCH v2 02/12] remoteproc: stm32: Request IRQ with platform device Mathieu Poirier
2020-05-14 4:57 ` Bjorn Andersson
2020-04-24 20:24 ` [PATCH v2 03/12] remoteproc: stm32: Decouple rproc from DT parsing Mathieu Poirier
2020-04-29 13:37 ` Arnaud POULIQUEN
2020-04-30 20:58 ` Mathieu Poirier
2020-05-14 4:59 ` Bjorn Andersson
2020-04-24 20:24 ` [PATCH v2 04/12] remoteproc: stm32: Remove memory translation " Mathieu Poirier
2020-05-14 5:03 ` Bjorn Andersson
2020-04-24 20:24 ` [PATCH v2 05/12] remoteproc: stm32: Parse syscon that will manage M4 synchronisation Mathieu Poirier
2020-05-14 5:03 ` Bjorn Andersson
2020-04-24 20:24 ` [PATCH v2 06/12] remoteproc: stm32: Get coprocessor state Mathieu Poirier
2020-04-29 13:38 ` Arnaud POULIQUEN
2020-05-01 17:40 ` Mathieu Poirier
2020-04-24 20:25 ` [PATCH v2 07/12] remoteproc: stm32: Get loaded resource table for synchronisation Mathieu Poirier
2020-04-24 20:25 ` [PATCH v2 08/12] remoteproc: stm32: Introduce new start ops " Mathieu Poirier
2020-04-29 14:50 ` Arnaud POULIQUEN
2020-04-24 20:25 ` [PATCH v2 09/12] remoteproc: stm32: Update M4 state in stm32_rproc_stop() Mathieu Poirier
2020-04-29 14:52 ` Arnaud POULIQUEN
2020-04-24 20:25 ` [PATCH v2 10/12] remoteproc: stm32: Introduce new parse fw ops for synchronisation Mathieu Poirier
2020-05-14 5:13 ` Bjorn Andersson
2020-04-24 20:25 ` [PATCH v2 11/12] remoteproc: stm32: Introduce new loaded rsc " Mathieu Poirier
2020-05-14 5:15 ` Bjorn Andersson
2020-04-24 20:25 ` [PATCH v2 12/12] remoteproc: stm32: Set synchronisation state machine if needed Mathieu Poirier
2020-04-29 14:47 ` Arnaud POULIQUEN
2020-05-01 17:54 ` Mathieu Poirier
2020-04-29 15:08 ` Arnaud POULIQUEN [this message]
2020-05-01 17:59 ` [PATCH v2 00/12] remoteproc: stm32: Add support for synchronising with M4 Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=219771d3-b0a5-0ec7-7f20-d2055bcb0217@st.com \
--to=arnaud.pouliquen@st.com \
--cc=alexandre.torgue@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=loic.pallardy@st.com \
--cc=mathieu.poirier@linaro.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).