From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31B18C83000 for ; Wed, 29 Apr 2020 15:08:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 132392074A for ; Wed, 29 Apr 2020 15:08:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=st.com header.i=@st.com header.b="WU/9l2NU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727798AbgD2PIp (ORCPT ); Wed, 29 Apr 2020 11:08:45 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:12606 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726618AbgD2PIo (ORCPT ); Wed, 29 Apr 2020 11:08:44 -0400 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03TF8PQB004369; Wed, 29 Apr 2020 17:08:34 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=OrHsueskmIs43EdFBn1E0vUvKJn0/dh6AJ0xQ3uCkUU=; b=WU/9l2NUHJH3flwUdt93RKlSOQmpi7VFr8JCg6CpOnWjmxuv0b7ar/GvhNXzDhytHw6O bD9La1Beo83P0GFaqGWCOKMbllfsqlZwUQmfQqVEWZOqnGsECGZ5OwE0eKPy8MoiwS8l hzEuVg5D9cWA1zgd6h/nGnyOBmZByzpgribLJrtwFUQK+1mCd2wiHhG9nqDvb4XQRwDG nd7PUINXfID6uHt30ZPMQWW7a3x6XdTxL6GEsalwwGEaXz3v5V/QXkbaLsC27xc4TJaM zH1s/QnOFs7NG/c775sAO6DcdcJqJ7PzUDVQ5Vi6yHZ915hYmedzryzE30fgHiVzuToJ IQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 30mhq672ft-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Apr 2020 17:08:34 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4F1E310003A; Wed, 29 Apr 2020 17:08:34 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag3node1.st.com [10.75.127.7]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 3CE062AB39C; Wed, 29 Apr 2020 17:08:34 +0200 (CEST) Received: from lmecxl0889.tpe.st.com (10.75.127.45) by SFHDAG3NODE1.st.com (10.75.127.7) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 29 Apr 2020 17:08:33 +0200 Subject: Re: [PATCH v2 00/12] remoteproc: stm32: Add support for synchronising with M4 To: Mathieu Poirier , , , , CC: , , , , References: <20200424202505.29562-1-mathieu.poirier@linaro.org> From: Arnaud POULIQUEN Message-ID: <219771d3-b0a5-0ec7-7f20-d2055bcb0217@st.com> Date: Wed, 29 Apr 2020 17:08:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200424202505.29562-1-mathieu.poirier@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG7NODE3.st.com (10.75.127.21) To SFHDAG3NODE1.st.com (10.75.127.7) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-04-29_07:2020-04-29,2020-04-29 signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mathieu, On 4/24/20 10:24 PM, Mathieu Poirier wrote: > This patchset needs to be applied on top of this one [1]. > > It refactors the STM32 platform code in order to introduce support for > synchronising with the M4 remote processor that would have been started by > the boot loader or another entity. > > It carries the same functionatlity as the previeous revision but account > for changes in the remoteproc core to support synchronisation scenarios. > Some RB tags have been removed when the content of the patch has strayed > too far from the original version. See patch 3, 8, 9 and 12 for more > details. I reviewed the series, and made some tests on my side. FYI, I do not answer to patches when tagged "Reviewed-by: Loic Pallardy" and with no extra remark. So consider them as Reviewed-by me but not necessary to add the tag in commit, Reviewed-by: loic in commit is sufficient. Concerning tests, it works find except the crash recovery from a sync start. But i suppose that you know the limitation, waiting Loic patches[1] update :) [1]: https://lkml.org/lkml/2020/3/11/403 Thanks a lot for your work! Arnaud > > Tested on ST's mp157c board. > > Thanks, > Mathieu > > [1]. https://patchwork.kernel.org/project/linux-remoteproc/list/?series=277049 > [2]. https://patchwork.kernel.org/project/linux-remoteproc/list/?series=239877 > > Mathieu Poirier (12): > remoteproc: stm32: Decouple rproc from memory translation > remoteproc: stm32: Request IRQ with platform device > remoteproc: stm32: Decouple rproc from DT parsing > remoteproc: stm32: Remove memory translation from DT parsing > remoteproc: stm32: Parse syscon that will manage M4 synchronisation > remoteproc: stm32: Get coprocessor state > remoteproc: stm32: Get loaded resource table for synchronisation > remoteproc: stm32: Introduce new start ops for synchronisation > remoteproc: stm32: Update M4 state in stm32_rproc_stop() > remoteproc: stm32: Introduce new parse fw ops for synchronisation > remoteproc: stm32: Introduce new loaded rsc ops for synchronisation > remoteproc: stm32: Set synchronisation state machine if needed > > drivers/remoteproc/stm32_rproc.c | 262 ++++++++++++++++++++++++++++--- > 1 file changed, 244 insertions(+), 18 deletions(-) >