From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC75FC433E1 for ; Fri, 14 Aug 2020 10:04:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B4EF20781 for ; Fri, 14 Aug 2020 10:04:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727829AbgHNKEJ (ORCPT ); Fri, 14 Aug 2020 06:04:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:43908 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726012AbgHNKEJ (ORCPT ); Fri, 14 Aug 2020 06:04:09 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6BDFBAE65; Fri, 14 Aug 2020 10:04:30 +0000 (UTC) Message-ID: <21baf85fa476f62a56895d77fa76dc0d73c1b3a0.camel@suse.de> Subject: Re: [PATCH v5 0/9] Raspberry Pi 4 USB firmware initialization rework From: Nicolas Saenz Julienne To: Greg KH , Florian Fainelli Cc: robh@kernel.org, wahrenst@gmx.net, p.zabel@pengutronix.de, andy.shevchenko@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, tim.gover@raspberrypi.org, linux-pci@vger.kernel.org, helgaas@kernel.org, mathias.nyman@linux.intel.com, lorenzo.pieralisi@arm.com Date: Fri, 14 Aug 2020 12:04:05 +0200 In-Reply-To: <20200814061105.GG1409566@kroah.com> References: <20200629161845.6021-1-nsaenzjulienne@suse.de> <01e4b87c-d287-fd72-9f9c-545539127a50@gmail.com> <20200814061105.GG1409566@kroah.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-08-14 at 08:11 +0200, Greg KH wrote: > On Thu, Aug 13, 2020 at 12:17:49PM -0700, Florian Fainelli wrote: > > > > On 8/13/2020 3:01 AM, Nicolas Saenz Julienne wrote: > > > Hi everyone. > > > > > > On Mon, 2020-06-29 at 18:18 +0200, Nicolas Saenz Julienne wrote: > > > > On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be > > > > loaded directly from an EEPROM or, if not present, by the SoC's > > > > co-processor, VideoCore. This series reworks how we handle this. > > > > > > > > The previous solution makes use of PCI quirks and exporting platform > > > > specific functions. Albeit functional it feels pretty shoehorned. This > > > > proposes an alternative way of handling the triggering of the xHCI chip > > > > initialization trough means of a reset controller. > > > > > > > > The benefits are pretty evident: less platform churn in core xHCI code, > > > > and no explicit device dependency management in pcie-brcmstb. > > > > > > > > Note that patch #1 depends on another series[1], that was just applied > > > > into the clk maintainer's tree. > > > > > > > > The series is based on v5.8-rc3 > > > > > > > > v3: https://www.spinics.net/lists/arm-kernel/msg813612.html > > > > v2: https://lkml.org/lkml/2020/6/9/875 > > > > v1: https://lore.kernel.org/linux-usb/20200608192701.18355-1-nsaenzjulienne@suse.de/T/#t > > > > > > > > [1] https://lore.kernel.org/linux-clk/159304773261.62212.983376627029743900@swboyd.mtv.corp.google.com/T/#t > > > > > > > > --- > > > > > > We were waiting on a dependency to be merged upstream to get this. They are now > > > in, so could we move things forward? > > > > > > I can take the device tree patches, I guess philipp can take the reset > > > controller code. But I'm not so sure who should be taking the PCI/USB > > > counterparts. > > > > Should we route everything through the USB tree since that is where the > > changes that do require synchronization with other subsystems and DTS is > > needed the most? > > -- > > Florian > > That's fine with me, if everyone else is ok with it :) Sounds good to me.