From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Benjamin Thiel <b.thiel@posteo.de>,
Borislav Petkov <bp@alien8.de>, Juergen Gross <jgross@suse.com>
Cc: x86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/xen: Fix a -Wmissing prototypes warning for xen_start_kernel()
Date: Mon, 8 Jun 2020 15:30:13 -0400 [thread overview]
Message-ID: <21d6821e-e488-138e-a0be-2177c4aa13b2@oracle.com> (raw)
In-Reply-To: <20200606142721.19486-1-b.thiel@posteo.de>
On 6/6/20 10:27 AM, Benjamin Thiel wrote:
> Fix:
>
> arch/x86/xen/enlighten_pv.c:1212:34:
> warning: no previous prototype for ‘xen_start_kernel’ [-Wmissing-prototypes]
> asmlinkage __visible void __init xen_start_kernel(void)
>
> Add a prototype for xen_start_kernel() in a separate xen-specific header.
TBH I am not sure it's worth a new header file for a routine that is
only called from assembly (and never returns). I'd just add the
prototype right above function definition, with a comment describing
why. I see a few examples of this in the tree. Or maybe we even have an
attribute for this case?
(I also suspect the same may be needed for xen_prepare_pvh() BTW).
-boris
next prev parent reply other threads:[~2020-06-08 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 14:27 [PATCH] x86/xen: Fix a -Wmissing prototypes warning for xen_start_kernel() Benjamin Thiel
2020-06-08 19:30 ` Boris Ostrovsky [this message]
2020-06-08 19:42 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21d6821e-e488-138e-a0be-2177c4aa13b2@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=b.thiel@posteo.de \
--cc=bp@alien8.de \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).