From: Vasily Averin <vvs@virtuozzo.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, "Roman Gushchin" <guro@fb.com>,
"Christian Brauner" <christian.brauner@ubuntu.com>,
"Michal Koutný" <mkoutny@suse.com>,
"Serge Hallyn" <serge@hallyn.com>,
cgroups@vger.kernel.org, "Michal Hocko" <mhocko@suse.com>
Subject: Re: [PATCH v2 1/1] memcg: enable accounting for pids in nested pid namespaces
Date: Wed, 14 Jul 2021 09:31:34 +0300 [thread overview]
Message-ID: <21db0c2c-45ea-fded-9633-7b76ab2b1083@virtuozzo.com> (raw)
In-Reply-To: <8b6de616-fd1a-02c6-cbdb-976ecdcfa604@virtuozzo.com>
Dear Andrew,
could you please pick up this patch and add
Reviewed-by: Shakeel Butt <shakeelb@google.com>
Thank you,
Vasily Averin
On 4/24/21 2:54 PM, Vasily Averin wrote:
> Commit 5d097056c9a0 ("kmemcg: account certain kmem allocations to memcg")
> enabled memcg accounting for pids allocated from init_pid_ns.pid_cachep,
> but forgot to adjust the setting for nested pid namespaces.
> As a result, pid memory is not accounted exactly where it is really needed,
> inside memcg-limited containers with their own pid namespaces.
>
> Pid was one the first kernel objects enabled for memcg accounting.
> init_pid_ns.pid_cachep marked by SLAB_ACCOUNT and we can expect that
> any new pids in the system are memcg-accounted.
>
> Though recently I've noticed that it is wrong. nested pid namespaces creates
> own slab caches for pid objects, nested pids have increased size because contain
> id both for all parent and for own pid namespaces. The problem is that these slab
> caches are _NOT_ marked by SLAB_ACCOUNT, as a result any pids allocated in
> nested pid namespaces are not memcg-accounted.
>
> Pid struct in nested pid namespace consumes up to 500 bytes memory,
> 100000 such objects gives us up to ~50Mb unaccounted memory,
> this allow container to exceed assigned memcg limits.
>
> Fixes: 5d097056c9a0 ("kmemcg: account certain kmem allocations to memcg")
> Cc: stable@vger.kernel.org
> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
> Reviewed-by: Michal Koutný <mkoutny@suse.com>
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
> Acked-by: Roman Gushchin <guro@fb.com>
> ---
> kernel/pid_namespace.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c
> index 6cd6715..a46a372 100644
> --- a/kernel/pid_namespace.c
> +++ b/kernel/pid_namespace.c
> @@ -51,7 +51,8 @@ static struct kmem_cache *create_pid_cachep(unsigned int level)
> mutex_lock(&pid_caches_mutex);
> /* Name collision forces to do allocation under mutex. */
> if (!*pkc)
> - *pkc = kmem_cache_create(name, len, 0, SLAB_HWCACHE_ALIGN, 0);
> + *pkc = kmem_cache_create(name, len, 0,
> + SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT, 0);
> mutex_unlock(&pid_caches_mutex);
> /* current can fail, but someone else can succeed. */
> return READ_ONCE(*pkc);
>
prev parent reply other threads:[~2021-07-14 6:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7b777e22-5b0d-7444-343d-92cbfae5f8b4@virtuozzo.com>
2021-04-24 11:54 ` [PATCH v2 0/1] memcg: enable accounting for pids in nested pid namespaces Vasily Averin
2021-04-24 11:54 ` [PATCH v2 1/1] " Vasily Averin
2021-04-26 19:39 ` Shakeel Butt
2021-07-14 6:31 ` Vasily Averin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21db0c2c-45ea-fded-9633-7b76ab2b1083@virtuozzo.com \
--to=vvs@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=guro@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=mkoutny@suse.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).