From: Andy Lutomirski <luto@kernel.org>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>
Cc: linux-security-module <linux-security-module@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Luis R. Rodriguez" <mcgrof@suse.com>,
"AKASHI, Takahiro" <takahiro.akashi@linaro.org>
Subject: Re: [RFC PATCH v1] fw_lockdown: new micro LSM module to prevent loading unsigned firmware
Date: Mon, 2 Apr 2018 17:42:22 -0700 [thread overview]
Message-ID: <21dd4b88-f6e7-f6bb-e34d-ba8ef3755622@kernel.org> (raw)
In-Reply-To: <1510347775.3549.2.camel@linux.vnet.ibm.com>
On 11/10/2017 01:02 PM, Mimi Zohar wrote:
> If the kernel is locked down and IMA-appraisal is not enabled, prevent
> loading of unsigned firmware.
> diff --git a/security/fw_lockdown/Kconfig b/security/fw_lockdown/Kconfig
> new file mode 100644
> index 000000000000..d6aef6ce8fee
> --- /dev/null
> +++ b/security/fw_lockdown/Kconfig
> @@ -0,0 +1,6 @@
> +config SECURITY_FW_LOCKDOWN
> + bool "Prevent loading unsigned firmware"
> + depends on LOCK_DOWN_KERNEL
> + default y
> + help
> + Prevent loading unsigned firmware in lockdown mode,
Please be honest about what this does. This option makes your system
useless if you don't use IMA-Appraisal and it offers a particular
security benefit if you do you IMA-Appraisal. How about making it
depend on IMA-Appraisal? Change the name to
SECURITY_ONLY_LOAD_IMA_APPRAISED_FIRMWARE and adjust the text
accordingly, please.
> +/**
> + * fw_lockdown_read_file - prevent loading of unsigned firmware
> + * @file: pointer to firmware
> + * @read_id: caller identifier
> + *
> + * Prevent loading of unsigned firmware in lockdown mode.
That comment gives a highly misleading impression of what this function
does.
> + */
> +static int fw_lockdown_read_file(struct file *file, enum kernel_read_file_id id)
next prev parent reply other threads:[~2018-04-03 0:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 21:02 [RFC PATCH v1] fw_lockdown: new micro LSM module to prevent loading unsigned firmware Mimi Zohar
2017-11-10 22:39 ` Luis R. Rodriguez
2017-11-11 23:04 ` Mimi Zohar
2017-11-10 22:45 ` Casey Schaufler
2018-04-03 0:42 ` Andy Lutomirski [this message]
2018-04-03 16:56 ` Luis R. Rodriguez
2018-04-03 17:06 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21dd4b88-f6e7-f6bb-e34d-ba8ef3755622@kernel.org \
--to=luto@kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=takahiro.akashi@linaro.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).