From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Valentina-Camelia Bojan <bojan.valentinacamelia@gmail.com>
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] include/linux: fix checkpatch issues
Date: Mon, 16 Mar 2015 23:53:57 +0100 [thread overview]
Message-ID: <2201843.AvYkyS9n8n@vostro.rjw.lan> (raw)
In-Reply-To: <1426294744-31382-1-git-send-email-bojan.valentinacamelia@gmail.com>
On Saturday, March 14, 2015 02:59:04 AM Valentina-Camelia Bojan wrote:
> Fix checkpatch issues of the following type:
> * ERROR: "foo * bar" should be "foo *bar"
> * WARNING: space prohibited between function name and open parenthesis '('
>
> Signed-off-by: Valentina-Camelia Bojan <bojan.valentinacamelia@gmail.com>
checkpatch.pl is for *new* *patches* and not for the existing code. And this
is not helpful.
Not applied.
> ---
> include/linux/acpi.h | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index 24c7aa8..2f16a08 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -115,15 +115,15 @@ static inline void acpi_initrd_override(void *data, size_t size)
> (!entry) || (unsigned long)entry + sizeof(*entry) > end || \
> ((struct acpi_subtable_header *)entry)->length < sizeof(*entry))
>
> -char * __acpi_map_table (unsigned long phys_addr, unsigned long size);
> +char *__acpi_map_table(unsigned long phys_addr, unsigned long size);
> void __acpi_unmap_table(char *map, unsigned long size);
> int early_acpi_boot_init(void);
> -int acpi_boot_init (void);
> -void acpi_boot_table_init (void);
> -int acpi_mps_check (void);
> -int acpi_numa_init (void);
> +int acpi_boot_init(void);
> +void acpi_boot_table_init(void);
> +int acpi_mps_check(void);
> +int acpi_numa_init(void);
>
> -int acpi_table_init (void);
> +int acpi_table_init(void);
> int acpi_table_parse(char *id, acpi_tbl_table_handler handler);
> int __init acpi_parse_entries(char *id, unsigned long table_size,
> acpi_tbl_entry_handler handler,
> @@ -136,14 +136,14 @@ int __init acpi_table_parse_entries(char *id, unsigned long table_size,
> int acpi_table_parse_madt(enum acpi_madt_type id,
> acpi_tbl_entry_handler handler,
> unsigned int max_entries);
> -int acpi_parse_mcfg (struct acpi_table_header *header);
> -void acpi_table_print_madt_entry (struct acpi_subtable_header *madt);
> +int acpi_parse_mcfg(struct acpi_table_header *header);
> +void acpi_table_print_madt_entry(struct acpi_subtable_header *madt);
>
> /* the following four functions are architecture-dependent */
> -void acpi_numa_slit_init (struct acpi_table_slit *slit);
> -void acpi_numa_processor_affinity_init (struct acpi_srat_cpu_affinity *pa);
> +void acpi_numa_slit_init(struct acpi_table_slit *slit);
> +void acpi_numa_processor_affinity_init(struct acpi_srat_cpu_affinity *pa);
> void acpi_numa_x2apic_affinity_init(struct acpi_srat_x2apic_cpu_affinity *pa);
> -int acpi_numa_memory_affinity_init (struct acpi_srat_mem_affinity *ma);
> +int acpi_numa_memory_affinity_init(struct acpi_srat_mem_affinity *ma);
> void acpi_numa_arch_fixup(void);
>
> #ifdef CONFIG_ACPI_HOTPLUG_CPU
> @@ -166,9 +166,9 @@ extern u32 acpi_irq_not_handled;
> extern int sbf_port;
> extern unsigned long acpi_realmode_flags;
>
> -int acpi_register_gsi (struct device *dev, u32 gsi, int triggering, int polarity);
> -int acpi_gsi_to_irq (u32 gsi, unsigned int *irq);
> -int acpi_isa_irq_to_gsi (unsigned isa_irq, u32 *gsi);
> +int acpi_register_gsi(struct device *dev, u32 gsi, int triggering, int polarity);
> +int acpi_gsi_to_irq(u32 gsi, unsigned int *irq);
> +int acpi_isa_irq_to_gsi(unsigned isa_irq, u32 *gsi);
>
> #ifdef CONFIG_X86_IO_APIC
> extern int acpi_get_override_irq(u32 gsi, int *trigger, int *polarity);
> @@ -180,14 +180,14 @@ extern int acpi_get_override_irq(u32 gsi, int *trigger, int *polarity);
> * If this matches the last registration, any IRQ resources for gsi
> * are freed.
> */
> -void acpi_unregister_gsi (u32 gsi);
> +void acpi_unregister_gsi(u32 gsi);
>
> struct pci_dev;
>
> -int acpi_pci_irq_enable (struct pci_dev *dev);
> +int acpi_pci_irq_enable(struct pci_dev *dev);
> void acpi_penalize_isa_irq(int irq, int active);
>
> -void acpi_pci_irq_disable (struct pci_dev *dev);
> +void acpi_pci_irq_disable(struct pci_dev *dev);
>
> extern int ec_read(u8 addr, u8 *val);
> extern int ec_write(u8 addr, u8 val);
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2015-03-16 22:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-14 0:59 [PATCH] include/linux: fix checkpatch issues Valentina-Camelia Bojan
2015-03-16 22:53 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2201843.AvYkyS9n8n@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=bojan.valentinacamelia@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).