From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BCCC0044C for ; Wed, 31 Oct 2018 18:48:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1733F20821 for ; Wed, 31 Oct 2018 18:48:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="vzlkoZ2t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1733F20821 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730704AbeKADr7 (ORCPT ); Wed, 31 Oct 2018 23:47:59 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:33614 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730176AbeKADr6 (ORCPT ); Wed, 31 Oct 2018 23:47:58 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9VIiHtj134037; Wed, 31 Oct 2018 18:48:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=thdYZ+IWw+c5cWRgqS1fTV7cfSUMA2Me6ZPD3o/lOLk=; b=vzlkoZ2tNwUtNNNpmlEdxISkq+53Qffr/Anl0mI9/H2H+VNJV20PavFlJo9TUb2roOlp KHwuW0xqUBhUB4GBDevtucN/fnchhGDwStXMM/UimxIPnEN3l5uC7ncfnmMxKZpzCECV Hv7pbVQIe43XbVmyPuP25Gq6ACLegIv/tUox2gQIE9wqbaM18VHex4NYc7bPGv0/9Ch5 gdWamr/4YTlE1YRwGnAaK87qNdqjsPnf3HvJO0Fomhp5p3w/CA6XGrJk789Mj9+accHg O+7DnvKGPQ40Jx5lXGrRMJD1k6WxWPFishTfkF8dGVavsCRF0MgIOG7R+2YqKlAXf0SG Jw== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2ncgnr4ypp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Oct 2018 18:48:11 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w9VIm6Lo016658 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Oct 2018 18:48:06 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w9VIm5s5027929; Wed, 31 Oct 2018 18:48:05 GMT Received: from [10.209.243.127] (/10.209.243.127) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 31 Oct 2018 11:48:04 -0700 Subject: Re: [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver To: Marc Zyngier , Grygorii Strashko , Lokesh Vutla Cc: Nishanth Menon , Santosh Shilimkar , Rob Herring , tglx@linutronix.de, jason@lakedaemon.net, Linux ARM Mailing List , linux-kernel@vger.kernel.org, Tero Kristo , Sekhar Nori , Device Tree Mailing List , Peter Ujfalusi References: <20181018154017.7112-1-lokeshvutla@ti.com> <20181018154017.7112-10-lokeshvutla@ti.com> <9969f24c-cdb0-1f5c-d0f4-b1c1f587325c@ti.com> <86va5ssrfm.wl-marc.zyngier@arm.com> <2369ea50-55db-c97b-5b43-99d572c97dc9@ti.com> <18df8960-9165-ba50-2c25-9f00d32198e8@oracle.com> From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: <2207fc72-22a6-b216-7b98-7c8c7768f002@oracle.com> Date: Wed, 31 Oct 2018 11:48:00 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9063 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810310154 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/31/2018 11:42 AM, Marc Zyngier wrote: > On 31/10/18 18:38, Santosh Shilimkar wrote: >> On 10/31/2018 11:21 AM, Marc Zyngier wrote: >>> Hi Grygorii, >>> >> >> [...] >> >>> >>> Well, I'm convinced that we do not want a networking driver to be tied >>> to an interrupt architecture, and that the two should be completely >>> independent. But that's my own opinion. I can only see two solutions >>> moving forward: >>> >>> 1) You make the IA a real interrupt controller that exposes real >>> interrupts (one per event), and write your networking driver >>> independently of the underlying interrupt architecture. >>> >>> 2) you make the IA an integral part of your network driver, not exposing >>> anything outside of it, and limiting the interactions with the IR >>> *through the standard IRQ API*. You duplicate this knowledge throughout >>> the other client drivers. >>> >>> I believe that (2) would be a massive design mistake as it locks the >>> driver to a single of the HW (and potentially a single revision of the >>> firmware) while (1) gives you the required level of flexibility by >>> hiding the whole event "concept" at a single location. >>> >>> Yes, (1) makes you rewrite your existing, out of tree drivers. Oh well... >>> >> My preference is also not tie the network driver with IA. BTW, this is >> very standard functionality with other network drivers too. And this >> is handled using MSI-X. >> >> So strong NO for 1) from me as well. > > Err. Are you opposing to (1) or (2)? From the above, I cannot really > tell... ;-) > I mixed it up, sorry. I meant NO for (2), i.e No for making IA part of the network driver. Regards, Santosh