From: Chengming Zhou <zhouchengming@bytedance.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: tj@kernel.org, mkoutny@suse.com, surenb@google.com,
gregkh@linuxfoundation.org, corbet@lwn.net, mingo@redhat.com,
peterz@infradead.org, songmuchun@bytedance.com,
cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 10/10] sched/psi: per-cgroup PSI accounting disable/re-enable interface
Date: Wed, 24 Aug 2022 18:55:01 +0800 [thread overview]
Message-ID: <2207ff74-a5ca-8324-0e10-717f235ca161@bytedance.com> (raw)
In-Reply-To: <YwX2jC2UQ/zeY2E8@cmpxchg.org>
On 2022/8/24 17:59, Johannes Weiner wrote:
> Hi Chengming,
>
> Thanks for incorporating all the feedback. I have a few nitpicks
> below, but with those considered, please add:
>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>
> On Wed, Aug 24, 2022 at 04:18:29PM +0800, Chengming Zhou wrote:
>> @@ -5171,12 +5220,19 @@ static struct cftype cgroup_base_files[] = {
>> {
>> .name = "irq.pressure",
>> .flags = CFTYPE_PRESSURE,
>> + .file_offset = offsetof(struct cgroup, psi_files[PSI_IRQ]),
>> .seq_show = cgroup_irq_pressure_show,
>> .write = cgroup_irq_pressure_write,
>> .poll = cgroup_pressure_poll,
>> .release = cgroup_pressure_release,
>> },
>> #endif
>> + {
>> + .name = "cgroup.pressure",
>> + .flags = CFTYPE_PRESSURE,
>> + .seq_show = cgroup_psi_show,
>> + .write = cgroup_psi_write,
>
> To match the naming convention, these should be called
> cgroup_pressure_show() and cgroup_pressure_write().
Hello,
I forgot to change the names, will do.
>
>> @@ -745,6 +745,14 @@ static void psi_group_change(struct psi_group *group, int cpu,
>> if (set & (1 << t))
>> groupc->tasks[t]++;
>>
>> + if (!group->enabled) {
>> + if (groupc->state_mask & (1 << PSI_NONIDLE))
>> + record_times(groupc, now);
>
> Thanks for the explanation in the other thread, it made sense. But can
> you please add a comment to document it? Something like:
>
> /*
> * On the first group change after disabling PSI, conclude
> * the current state and flush its time. This is unlikely
> * to matter to the user, but aggregation (get_recent_times)
> * may have already incorporated the live state into times_prev;
> * avoid a delta sample underflow when PSI is later re-enabled.
> */
>
> An unlikely() would also make sense on that branch.
The comment is very helpful, unlikely() is also very good point,
will add in the next version.
>
>> @@ -1081,6 +1092,40 @@ void cgroup_move_task(struct task_struct *task, struct css_set *to)
>>
>> task_rq_unlock(rq, task, &rf);
>> }
>> +
>> +void psi_cgroup_enabled_sync(struct psi_group *group)
>> +{
>> + int cpu;
>> +
>> + /*
>> + * After we disable psi_group->enabled, we don't actually
>> + * stop percpu tasks accounting in each psi_group_cpu,
>> + * instead only stop test_state() loop, record_times()
>> + * and averaging worker, see psi_group_change() for details.
>> + *
>> + * When disable cgroup PSI, this function has nothing to sync
>> + * since cgroup pressure files are hidden and percpu psi_group_cpu
>> + * would see !psi_group->enabled and only do task accounting.
>> + *
>> + * When re-enable cgroup PSI, this function use psi_group_change()
>> + * to get correct state mask from test_state() loop on tasks[],
>> + * and restart groupc->state_start from now, use .clear = .set = 0
>> + * here since no task status really changed.
>> + */
>> + if (!group->enabled)
>> + return;
>
> Thanks for adding the comment, that's helpful.
>
> I think the function would be a tad clearer and self-documenting if
> you called it psi_cgroup_restart(), and only call it on enabling.
Ok, it's better, will do.
Thanks for your review!
>
>> + for_each_possible_cpu(cpu) {
>> + struct rq *rq = cpu_rq(cpu);
>> + struct rq_flags rf;
>> + u64 now;
>> +
>> + rq_lock_irq(rq, &rf);
>> + now = cpu_clock(cpu);
>> + psi_group_change(group, cpu, 0, 0, now, true);
>> + rq_unlock_irq(rq, &rf);
>> + }
>> +}
>> #endif /* CONFIG_CGROUPS */
>
> Thanks,
> Johannes
next prev parent reply other threads:[~2022-08-24 10:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 8:18 [PATCH v3 00/10] sched/psi: some optimization and extension Chengming Zhou
2022-08-24 8:18 ` [PATCH v3 01/10] sched/psi: fix periodic aggregation shut off Chengming Zhou
2022-08-24 8:18 ` [PATCH v3 02/10] sched/psi: don't create cgroup PSI files when psi_disabled Chengming Zhou
2022-08-24 8:18 ` [PATCH v3 03/10] sched/psi: save percpu memory when !psi_cgroups_enabled Chengming Zhou
2022-08-24 8:18 ` [PATCH v3 04/10] sched/psi: move private helpers to sched/stats.h Chengming Zhou
2022-08-24 8:18 ` [PATCH v3 05/10] sched/psi: optimize task switch inside shared cgroups again Chengming Zhou
2022-08-24 14:06 ` Johannes Weiner
2022-08-24 15:30 ` Chengming Zhou
2022-08-24 8:18 ` [PATCH v3 06/10] sched/psi: remove NR_ONCPU task accounting Chengming Zhou
2022-08-24 8:18 ` [PATCH v3 07/10] sched/psi: add PSI_IRQ to track IRQ/SOFTIRQ pressure Chengming Zhou
2022-08-24 10:46 ` Johannes Weiner
2022-08-24 11:53 ` Chengming Zhou
2022-08-24 8:18 ` [PATCH v3 08/10] sched/psi: consolidate cgroup_psi() Chengming Zhou
2022-08-24 10:19 ` Johannes Weiner
2022-08-24 8:18 ` [PATCH v3 09/10] sched/psi: cache parent psi_group to speed up groups iterate Chengming Zhou
2022-08-24 10:18 ` Johannes Weiner
2022-08-24 10:48 ` Chengming Zhou
2022-08-24 8:18 ` [PATCH v3 10/10] sched/psi: per-cgroup PSI accounting disable/re-enable interface Chengming Zhou
2022-08-24 9:59 ` Johannes Weiner
2022-08-24 10:55 ` Chengming Zhou [this message]
2022-08-25 12:28 ` Chengming Zhou
2022-08-25 13:20 ` Johannes Weiner
2022-08-25 13:29 ` Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2207ff74-a5ca-8324-0e10-717f235ca161@bytedance.com \
--to=zhouchengming@bytedance.com \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
--cc=songmuchun@bytedance.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).