From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965066AbbLHPAo (ORCPT ); Tue, 8 Dec 2015 10:00:44 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:62552 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964989AbbLHPAn (ORCPT ); Tue, 8 Dec 2015 10:00:43 -0500 From: Arnd Bergmann To: Neil Armstrong Cc: nicolas.ferre@atmel.com, davem@davemloft.net, harini.katakam@xilinx.com, boris.brezillon@free-electrons.com, alexandre.belloni@free-electrons.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, joshc@ni.com Subject: Re: [PATCH v2 net-next 2/3] net: ethernet: cadence-macb: Add fallback to read DT provided caps Date: Tue, 08 Dec 2015 16:00:20 +0100 Message-ID: <2217940.QPNsks7uyL@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1449582726-6148-3-git-send-email-narmstrong@baylibre.com> References: <1449485914-12883-1-git-send-email-narmstrong@baylibre.com> <1449582726-6148-1-git-send-email-narmstrong@baylibre.com> <1449582726-6148-3-git-send-email-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:axrA/18R/IFgG86smIS9jmr7NUPAjEXIo1CN4zv4mJKRUhhDMAt IDHlIbm/hquiavewG9Rsrtgxh4hB0HWoR/n9+5NLaaK9Njk5bVRQb2hKtiCpi4qSYoPT0p3 /wiU3a+TEwRHAbLzog8JgmKytKljrlCeGR9YEqr9ylc9Cglm1KssTzpTeW0M2bCOsceGHFM enQVUUrEWiJtIghB40sIg== X-UI-Out-Filterresults: notjunk:1;V01:K0:FqW9wTy3niw=:WmqWjcml5Mxhb7Frff69dk rkjbpkZBfsdSXMyOLW5HCCbEnp3sx9lEn7Ad/Fr0q6l9wu5n8nfFEs63+nGi/hxYMncCmvfBS GfZGuYnJ43Dn7PrzYfxnBgkdUTOTDPYOaEC8qm6vGZnlKedGD21O2p7S8o6r2VnBAOCnuAhHJ JmWvvUoDUCnHraQ0r6j05mXZlR5MYvR1mPimf1TGSzpaSZHpPWKB5Fxm79OjC9ZkAwqoPNJ3W RcpVgT9IFOnaBRqWKlL9Pi8pBl0Bzxlsy7ATSwdKfERzUUe+duK5Gdt6P0Ix4hNer59RAavUG VyaGDERtfNIErAmtxpVXP2/x2XNYNtH41JoybJKsDA38oCnFacOr9B/G/hLCCzI7fNzLkXCd3 W7uomldfahbnLm0xmYLAzeW0+LqOBFwZ1vAHpJhhvIs0VSfgXOAWLVzfG9HaHDpbK+/K+oCjf NojvVKrtAlg73QP55U5Yo2LKd2NitkkrqXfa995h0wG6/bTHfBFCmRUYB4UAksWEBubaFwXuB K8+uXdsfUcTWMrQ+s5KNJwIn4DQ54ITiKBG79/6/yQ/8cYACDJ+ss+wdJdRBd61+MdCp8THRZ R35EktAmPwXE4GQd7wjM4axuYOafMx4M+aNWVOgabTf0yFrzxChlWa3dw8WFI0PbMIxVEh+t3 HG/ZFh6rEroZga3uXCtl6QeT1S9KtoxVTb3JEDTso4sYGvj9ZkivptMfqnEGtHhEZn5s8nPzw HsFPjjTpt+lU46ME Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 08 December 2015 14:52:05 Neil Armstrong wrote: > Add 1:1 mapping of software defines caps parsing from DT in case the > generic macb compatible form is used. > These properties will provide support for futures implementations > only defined from DT without need to update the driver code to support > new variants. > > Signed-off-by: Neil Armstrong > Translating the Linux implementation specific configuration into DT properties directly is usually not the best way. Could we instead have a lookup table by compatible string to set the flags? It seems that there are lots of different flags but only a couple of different users of this IP block. Also, the fact that you are now adding yet another quirk tells me that the set you define today is unlikely to cover all the future requirements. Arnd