linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Prashant Gaikwad <pgaikwad@nvidia.com>,
	linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 8/8] memory: tegra: Introduce Tegra20 EMC driver
Date: Thu, 25 Oct 2018 21:36:33 +0300	[thread overview]
Message-ID: <221ac544-b57a-e85f-79ac-0b914615c9a9@gmail.com> (raw)
In-Reply-To: <20181025143853.GL21521@ulmo>

On 10/25/18 5:38 PM, Thierry Reding wrote:
> On Sun, Oct 21, 2018 at 09:30:52PM +0300, Dmitry Osipenko wrote:
>> Introduce driver for the External Memory Controller (EMC) found on Tegra20
>> chips, which controls the external DRAM on the board. The purpose of this
>> driver is to program memory timing for external memory on the EMC clock
>> rate change.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> Acked-by: Peter De Schrijver <pdeschrijver@nvidia.com>
>> ---
>>  drivers/memory/tegra/Kconfig       |  10 +
>>  drivers/memory/tegra/Makefile      |   1 +
>>  drivers/memory/tegra/tegra20-emc.c | 591 +++++++++++++++++++++++++++++
>>  3 files changed, 602 insertions(+)
>>  create mode 100644 drivers/memory/tegra/tegra20-emc.c
> 
> Applied to for-4.21/memory, thanks.

Thank you! 

> Though I did notice that there's quite a bit of code that's very similar
> between this and the existing Tegra124 driver, so I wonder if we can do
> a pass over them and refactor some of it as a follow-up.
I don't think this will really worth the effort.

      reply	other threads:[~2018-10-25 18:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-21 18:30 [PATCH v6 0/8] Tegra20 External Memory Controller driver Dmitry Osipenko
2018-10-21 18:30 ` [PATCH v6 1/8] dt: bindings: tegra20-emc: Document interrupt property Dmitry Osipenko
2018-10-25 14:25   ` Thierry Reding
2018-10-21 18:30 ` [PATCH v6 2/8] dt: bindings: tegra20-emc: Document clock property Dmitry Osipenko
2018-10-25 14:26   ` Thierry Reding
2018-10-21 18:30 ` [PATCH v6 3/8] dt: bindings: Move tegra20-emc binding to memory-controllers directory Dmitry Osipenko
2018-10-25 14:27   ` Thierry Reding
2018-10-21 18:30 ` [PATCH v6 4/8] ARM: dts: tegra20: Add interrupt entry to External Memory Controller Dmitry Osipenko
2018-10-25 14:28   ` Thierry Reding
2018-10-25 14:28   ` Thierry Reding
2018-10-21 18:30 ` [PATCH v6 5/8] ARM: dts: tegra20: Add clock " Dmitry Osipenko
2018-10-25 14:29   ` Thierry Reding
2018-10-21 18:30 ` [PATCH v6 6/8] clk: tegra20: Turn EMC clock gate into divider Dmitry Osipenko
2018-10-25 14:30   ` Thierry Reding
2018-10-21 18:30 ` [PATCH v6 7/8] clk: tegra20: Check whether direct PLLM sourcing is turned off for EMC Dmitry Osipenko
2018-10-25 14:31   ` Thierry Reding
2018-10-21 18:30 ` [PATCH v6 8/8] memory: tegra: Introduce Tegra20 EMC driver Dmitry Osipenko
2018-10-25 14:38   ` Thierry Reding
2018-10-25 18:36     ` Dmitry Osipenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=221ac544-b57a-e85f-79ac-0b914615c9a9@gmail.com \
    --to=digetx@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgaikwad@nvidia.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).