Re: [PATCH v10] mfd: mt6360: add pmic mt6360 driver

From: Matthias Brugger <matthias.bgg@gmail.com>
To: Lee Jones <lee.jones@linaro.org>,
	Gene Chen <gene.chen.richtek@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	gene_chen@richtek.com, Wilma.Wu@mediatek.com,
	shufan_lee@richtek.com, cy_huang@richtek.com
Subject: Re: [PATCH v10] mfd: mt6360: add pmic mt6360 driver
Date: Tue, 2 Jun 2020 11:43:54 +0200	[thread overview]
Message-ID: <2231bffe-27d1-6aee-4699-77d2f754beef@gmail.com> (raw)
In-Reply-To: <20200602082816.GC3714@dell>

On 02/06/2020 10:28, Lee Jones wrote:
> On Tue, 02 Jun 2020, Gene Chen wrote:
> 
>> From: Gene Chen <gene_chen@richtek.com>
>>
>> Add MFD driver for mt6360 pmic chip include Battery Charger/
>> USB_PD/Flash, LED/RGB and LED/LDO/Buck
>>
>> Signed-off-by: Gene Chen <gene_chen@richtek.com>
>> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> 
> I did not sign this off.
> 

You are right, you provided your Acked-for-MFD-by and took an earlier version of
the patch [1]. But as this didn't show up in linux-next I suppose you dropped it
afterwards because of kbuild test errors (deducing from the changes log).

I suppose if this errors are fixed now, we should be fine :)

Regards,
Matthias

[1]
https://lkml.kernel.org/lkml/1587641093-25441-1-git-send-email-gene.chen.richtek@gmail.com/T/#m75e8ee81950ee34e155eccd2dc5ad9b1d2cef40a

>> ---
>>  drivers/mfd/Kconfig        |  12 ++
>>  drivers/mfd/Makefile       |   1 +
>>  drivers/mfd/mt6360-core.c  | 424 +++++++++++++++++++++++++++++++++++++++++++++
>>  include/linux/mfd/mt6360.h | 240 +++++++++++++++++++++++++
>>  4 files changed, 677 insertions(+)
>>  create mode 100644 drivers/mfd/mt6360-core.c
>>  create mode 100644 include/linux/mfd/mt6360.h
>>
>> changelogs between v1 & v2
>> - include missing header file
>>
>> changelogs between v2 & v3
>> - add changelogs
>>
>> changelogs between v3 & v4
>> - fix Kconfig description
>> - replace mt6360_pmu_info with mt6360_pmu_data
>> - replace probe with probe_new
>> - remove unnecessary irq_chip variable
>> - remove annotation
>> - replace MT6360_MFD_CELL with OF_MFD_CELL
>>
>> changelogs between v4 & v5
>> - remove unnecessary parse dt function
>> - use devm_i2c_new_dummy_device
>> - add base-commit message
>>
>> changelogs between v5 & v6
>> - review return value
>> - remove i2c id_table
>> - use GPL license v2
>>
>> changelogs between v6 & v7
>> - add author description
>> - replace MT6360_REGMAP_IRQ_REG by REGMAP_IRQ_REG_LINE
>> - remove mt6360-private.h
>>
>> changelogs between v7 & v8
>> - fix kbuild auto reboot by include interrupt header
>>
>> changelogs between v8 & v9
>> - fix GPL license out of date
>> - add commit message about Acked-for-MFD-by
>>
>> changelogs between v9 & v10
> 
> v9 of this patch is already applied.
> 
> You cannot send a v10.
> 
>> - fix duplicate define of kbuild test reboot initializer-overrides
> 
> I fixed this already.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?h=for-mfd-next&id=098c4adf249c198519a4abebe482b1e6b8c50e47
> 
>> - sync commit message format
> 