From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934976AbeB1VXs (ORCPT ); Wed, 28 Feb 2018 16:23:48 -0500 Received: from mailoutvs4.siol.net ([213.250.19.137]:60828 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933957AbeB1VXk (ORCPT ); Wed, 28 Feb 2018 16:23:40 -0500 From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: maxime.ripard@free-electrons.com Cc: wens@csie.org, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, mturquette@baylibre.com, sboyd@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 00/16] Implement H3/H5 HDMI driver Date: Wed, 28 Feb 2018 22:23:35 +0100 Message-ID: <2235934.0TF68fluGz@jernej-laptop> In-Reply-To: <20180227222701.9716-1-jernej.skrabec@siol.net> References: <20180227222701.9716-1-jernej.skrabec@siol.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, Dne torek, 27. februar 2018 ob 23:26:45 CET je Jernej Skrabec napisal(a): > This series implements H3/H5 HDMI driver. It was tested on OrangePi 2 (H3), > OrangePi Plus2e (H3) and OrangePi PC2 (H5) with many resolutions and it > works well. Bug, which prevented correct operation for some resolutions, > is also fixed. > > Code is based on linux-next, next-20180226 tag. Today I tried on this series on next-20180228, but resolution switching doesn't really work. The reason for this is use of clk_set_rate_exclusive() in sun4i_tcon1_mode_set(). If I revert it to ordinary clk_set_rate() it works ok. I investigated a bit and it seems that clocks stays at first set even if tcon (the owner of exclusive lock) request the new one. Example: [ 69.325732] TCON clk wanted: 148500000 [ 69.325740] TCON real clk: 69272728 [ 69.325770] HDMI clk wanted: 148500000 [ 69.325773] HDMI real clk: 138545455 [ 69.325815] HDMI PHY clk wanted: 148500000 [ 69.325819] HDMI PHY real clk: 138545454 Is there anything I can do to help debug this? Best regards, Jernej