From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753004AbdBTMO5 convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Mon, 20 Feb 2017 07:14:57 -0500
Received: from mga02.intel.com ([134.134.136.20]:10077 "EHLO mga02.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752118AbdBTMOz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Feb 2017 07:14:55 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.35,186,1484035200"; 
   d="scan'208";a="67948917"
From: "Reshetova, Elena" <elena.reshetova@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
        "linux-audit@redhat.com" <linux-audit@redhat.com>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
        "tj@kernel.org" <tj@kernel.org>, "mingo@redhat.com" <mingo@redhat.com>,
        "hannes@cmpxchg.org" <hannes@cmpxchg.org>,
        "lizefan@huawei.com" <lizefan@huawei.com>,
        "acme@kernel.org" <acme@kernel.org>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "paul@paul-moore.com" <paul@paul-moore.com>,
        "eparis@redhat.com" <eparis@redhat.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "arnd@arndb.de" <arnd@arndb.de>, "luto@kernel.org" <luto@kernel.org>,
        Hans Liljestrand <ishkamiel@gmail.com>,
        Kees Cook <keescook@chromium.org>, David Windsor <dwindsor@gmail.com>
Subject: RE: [PATCH 06/19] kernel: convert perf_event_context.refcount from
 atomic_t to refcount_t
Thread-Topic: [PATCH 06/19] kernel: convert perf_event_context.refcount from
 atomic_t to refcount_t
Thread-Index: AQHSi2OQQy3izS2YiU+31lfJf9EflqFxsVuAgAAdkAA=
Date: Mon, 20 Feb 2017 12:14:49 +0000
Message-ID: <2236FBA76BA1254E88B949DDB74E612B41C4D90C@IRSMSX102.ger.corp.intel.com>
References: <1487585948-6401-1-git-send-email-elena.reshetova@intel.com>
 <1487585948-6401-7-git-send-email-elena.reshetova@intel.com>
 <20170220102825.GL6500@twins.programming.kicks-ass.net>
In-Reply-To: <20170220102825.GL6500@twins.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Mon, Feb 20, 2017 at 12:18:55PM +0200, Elena Reshetova wrote:
> > +++ b/kernel/events/core.c
> > @@ -1108,7 +1108,7 @@ static void perf_event_ctx_deactivate(struct
> perf_event_context *ctx)
> >
> >  static void get_ctx(struct perf_event_context *ctx)
> >  {
> > -	WARN_ON(!atomic_inc_not_zero(&ctx->refcount));
> > +	WARN_ON(!refcount_inc_not_zero(&ctx->refcount));
> >  }
> 
> You can change that to refcount_inc(), as that has the exact same
> semantics.

True, will fix. Thanks!