From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755601AbdDRGeP (ORCPT ); Tue, 18 Apr 2017 02:34:15 -0400 Received: from mga01.intel.com ([192.55.52.88]:21658 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753367AbdDRGeK (ORCPT ); Tue, 18 Apr 2017 02:34:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,218,1488873600"; d="scan'208";a="250373098" From: "Reshetova, Elena" To: Paul Moore CC: "linux-kernel@vger.kernel.org" , "cgroups@vger.kernel.org" , "linux-audit@redhat.com" , "linux-fsdevel@vger.kernel.org" , "peterz@infradead.org" , "gregkh@linuxfoundation.org" , "viro@zeniv.linux.org.uk" , "tj@kernel.org" , "mingo@redhat.com" , "hannes@cmpxchg.org" , "lizefan@huawei.com" , "acme@kernel.org" , "alexander.shishkin@linux.intel.com" , Eric Paris , "akpm@linux-foundation.org" , "arnd@arndb.de" , "luto@kernel.org" , Hans Liljestrand , Kees Cook , David Windsor Subject: RE: [PATCH 15/19] kernel: convert audit_tree.count from atomic_t to refcount_t Thread-Topic: [PATCH 15/19] kernel: convert audit_tree.count from atomic_t to refcount_t Thread-Index: AQHSi2OyWcwNjBKyxUGAIiRh3TjHfqFydKeAgACYa+CAC/tCgIBBvCEAgAo/+RA= Date: Tue, 18 Apr 2017 06:33:41 +0000 Message-ID: <2236FBA76BA1254E88B949DDB74E612B41C8C33F@IRSMSX102.ger.corp.intel.com> References: <1487585948-6401-1-git-send-email-elena.reshetova@intel.com> <1487585948-6401-16-git-send-email-elena.reshetova@intel.com> <2236FBA76BA1254E88B949DDB74E612B41C4DE27@IRSMSX102.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v3I6YTj6002947 > On Tue, Feb 28, 2017 at 5:11 PM, Paul Moore wrote: > > On Tue, Feb 21, 2017 at 2:15 AM, Reshetova, Elena > > wrote: > >>> On Mon, Feb 20, 2017 at 5:19 AM, Elena Reshetova > >>> wrote: > >>> > refcount_t type and corresponding API should be > >>> > used instead of atomic_t when the variable is used as > >>> > a reference counter. This allows to avoid accidental > >>> > refcounter overflows that might lead to use-after-free > >>> > situations. > >>> > > >>> > Signed-off-by: Elena Reshetova > >>> > Signed-off-by: Hans Liljestrand > >>> > Signed-off-by: Kees Cook > >>> > Signed-off-by: David Windsor > >>> > --- > >>> > kernel/audit_tree.c | 8 ++++---- > >>> > 1 file changed, 4 insertions(+), 4 deletions(-) > >>> > >>> No objection on my end, same for patch 16/19. > >>> > >>> I have no problem merging both these patches into the audit/next > >>> branch after the merge window, is that your goal or are you merging > >>> these via a different tree? > >> > >> Thank you Paul! I think it is better if they go through the trees they supposed to > go through > >> since this way they would get more testing and etc. So, please take the relevant > ones to your tree when the time is right. > >> > >> After the first round, I guess we will see what patches are not propagating and > then maybe take them via Kees tree. > > > > I just realized that include/linux/refcount.h didn't make it into > > v4.10 which means there is going to be delay until I merge them into > > the audit tree (I don't base the tree on -rc releases except under > > extreme circumstances). I've got the patches queued up in a private > > holding branch (I added #includes BTW) so I won't forget, but as a > > FYI, they likely won't make it in until v4.12. > > Quick update on this: I needed to rebase the audit/next branch for > other reasons so I've gone ahead and merged 15/19 and 16/19 into > audit/next; they should go to Linus during the next merge window. > Thanks for your patience. Thank you very much Paul! I just got back from holidays, so catching up with the mail slowly. Best Regards, Elena. > > -- > paul moore > www.paul-moore.com