From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752220AbdKXHgc convert rfc822-to-8bit (ORCPT ); Fri, 24 Nov 2017 02:36:32 -0500 Received: from mga05.intel.com ([192.55.52.43]:58318 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751790AbdKXHga (ORCPT ); Fri, 24 Nov 2017 02:36:30 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,445,1505804400"; d="scan'208";a="6425284" From: "Reshetova, Elena" To: Alasdair G Kergon CC: "dm-devel@redhat.com" , "keescook@chromium.org" , "snitzer@redhat.com" , "peterz@infradead.org" , "shli@kernel.org" , "koverstreet@google.com" , "linux-kernel@vger.kernel.org" , "linux-raid@vger.kernel.org" , "linux-bcache@vger.kernel.org" , "ejt@redhat.comg" , "kent.overstreet@gmail.com" , Zdenek Kabelac Subject: RE: [dm-devel] [PATCH 3/4] dm: convert dm_dev_internal.count from atomic_t to refcount_t Thread-Topic: [dm-devel] [PATCH 3/4] dm: convert dm_dev_internal.count from atomic_t to refcount_t Thread-Index: AQHTZHLMw1oIU3Dii0GTg8yMWjM14aMjJJsA Date: Fri, 24 Nov 2017 07:36:26 +0000 Message-ID: <2236FBA76BA1254E88B949DDB74E612B802C1F07@IRSMSX102.ger.corp.intel.com> References: <1508485059-21881-1-git-send-email-elena.reshetova@intel.com> <1508485059-21881-4-git-send-email-elena.reshetova@intel.com> <20171123154941.GA15790@agk-dp.fab.redhat.com> In-Reply-To: <20171123154941.GA15790@agk-dp.fab.redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDUwODNiMTEtZWQxMC00MmU3LWI0NDMtZGZkN2JlYjQzN2ZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiI2bGd0TERJM1kzQ3Q4WU5UdnNpOENYS1ZtRHZHalYyeXlCXC9Fd3YyUlZ6dmFDd3U5M0ZrZHFPK0lPV1ZmeHBjcSJ9 x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Fri, Oct 20, 2017 at 10:37:38AM +0300, Elena Reshetova wrote: > > } else if (dd->dm_dev->mode != (mode | dd->dm_dev->mode)) { > > r = upgrade_mode(dd, mode, t->md); > > if (r) > > return r; > > + refcount_inc(&dd->count); > > } > > Missing here: > > else > refcount_inc(&dd->count); > > ? Oh, yes, thanks for catching this! I think this got unnoticed so far and patch was merged, so I am going to send a followup patch now. Best Regards, Elena. > > Alasdair