From: Paul Boddie <paul@boddie.org.uk>
To: Paul Cercueil <paul@crapouillou.net>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
David Airlie <airlied@linux.ie>,
linux-mips <linux-mips@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Daniel Vetter <daniel@ffwll.ch>,
list@opendingux.net, Sam Ravnborg <sam@ravnborg.org>,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>
Subject: Re: [Letux-kernel] [PATCH 8/8] drm/ingenic: Attach bridge chain to encoders
Date: Tue, 10 Aug 2021 01:17:20 +0200 [thread overview]
Message-ID: <2242071.3D3ZAXhqrE@jason> (raw)
In-Reply-To: <0TYKXQ.YAJ6UYG2GTXS1@crapouillou.net>
On Monday, 9 August 2021 18:22:12 CEST Paul Cercueil wrote:
>
> Le lun., août 9 2021 at 13:14:03 +0200, H. Nikolaus Schaller
<hns@goldelico.com> a écrit :
> >
> > quick feedback: our HDMI on top compiles fine after fixing 2 merge
> > conflicts, but dos not yet work.
> > Will need some spare time with access to the CI20 board to research
> > the issue, i.e. can not give feedback immediately.
>
> Alright, no problem. I'll be back home in about 2 weeks and then I can
> test on my CI20 as well.
Just for reference, I looked into this initialisation failure. The HDMI
peripheral driver gets initialised satisfactorily...
dw-hdmi-ingenic 10180000.hdmi: Detected HDMI TX controller v1.31a with HDCP
(DWC HDMI 3D TX PHY)
dw-hdmi-ingenic 10180000.hdmi: registered DesignWare HDMI I2C bus driver
But then the reported error occurs in the DRM driver:
ingenic-drm 13050000.lcdc0: Unable to init connector
ingenic-drm: probe of 13050000.lcdc0 failed with error -22
This originates in a call to drm_bridge_connector_init from ingenic_drm_bind:
connector = drm_bridge_connector_init(drm, encoder);
The invoked function iterates over the registered bridges, one of which seems
to be the HDMI peripheral (it has bridge operations defined identically to
those specified in the Synopsys driver), but the type member of the drm_bridge
structure is set to 0 (DRM_MODE_CONNECTOR_Unknown).
I might expect the bridge to expose a type acquired from its connector, but I
don't see this propagation occurring in the Synopsys driver: dw_hdmi_probe
sets the bridge operations and other members of the drm_bridge structure, but
it doesn't set the type.
Also, it might be possible that dw_hdmi_connector_detect (exposed as the
detect operation) is not getting called, and this would explain why the
bridge's connector member does not have the connector_type set, either (since
it is also set to 0).
Paul
next prev parent reply other threads:[~2021-08-09 23:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 13:45 [PATCH 0/8] gpu/drm: ingenic-drm: Various improvements Paul Cercueil
2021-08-08 13:45 ` [PATCH 1/8] drm/ingenic: Remove dead code Paul Cercueil
2021-08-08 17:58 ` Thomas Zimmermann
2021-08-08 18:27 ` Joe Perches
2021-08-08 18:33 ` Paul Cercueil
2021-08-08 13:45 ` [PATCH 2/8] drm/ingenic: Simplify code by using hwdescs array Paul Cercueil
2021-08-08 18:42 ` Thomas Zimmermann
2021-08-08 22:22 ` Paul Cercueil
2021-08-08 13:45 ` [PATCH 3/8] drm/ingenic: Use standard drm_atomic_helper_commit_tail Paul Cercueil
2021-08-08 19:50 ` Christophe JAILLET
2021-08-08 20:09 ` Paul Cercueil
2021-08-08 20:15 ` Christophe JAILLET
2021-08-10 10:20 ` Daniel Vetter
2021-08-10 10:46 ` Paul Cercueil
2021-08-08 13:45 ` [PATCH 4/8] drm/ingenic: Add support for private objects Paul Cercueil
2021-08-08 13:45 ` [PATCH 5/8] drm/ingenic: Move IPU scale settings to private state Paul Cercueil
2021-08-08 13:45 ` [PATCH 6/8] drm/ingenic: Set DMA descriptor chain register when starting CRTC Paul Cercueil
2021-08-08 13:45 ` [PATCH 7/8] drm/ingenic: Upload palette before frame Paul Cercueil
2021-08-08 13:45 ` [PATCH 8/8] drm/ingenic: Attach bridge chain to encoders Paul Cercueil
2021-08-08 18:57 ` H. Nikolaus Schaller
2021-08-08 19:04 ` Paul Cercueil
2021-08-08 19:06 ` H. Nikolaus Schaller
2021-08-08 19:12 ` H. Nikolaus Schaller
2021-08-09 11:14 ` [Letux-kernel] " H. Nikolaus Schaller
2021-08-09 16:22 ` Paul Cercueil
2021-08-09 23:17 ` Paul Boddie [this message]
2021-08-10 7:52 ` Paul Cercueil
2021-08-10 21:15 ` Paul Boddie
2021-08-10 21:54 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2242071.3D3ZAXhqrE@jason \
--to=paul@boddie.org.uk \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=list@opendingux.net \
--cc=paul@crapouillou.net \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).