From: "Heiko Stübner" <heiko@sntech.de>
To: Lin Huang <hl@rock-chips.com>
Cc: seanpaul@chromium.org, airlied@linux.ie, zyw@rock-chips.com,
kishon@ti.com, dianders@chromium.org, briannorris@chromium.org,
linux-rockchip@lists.infradead.org, daniel.vetter@intel.com,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, eballetbo@gmail.com,
robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v7 1/5] drm/rockchip: add transfer function for cdn-dp
Date: Tue, 05 Jun 2018 15:42:11 +0200 [thread overview]
Message-ID: <2246202.0LhvmkcTbg@diego> (raw)
In-Reply-To: <1527061353-16902-1-git-send-email-hl@rock-chips.com>
Hi,
Am Mittwoch, 23. Mai 2018, 09:42:29 CEST schrieb Lin Huang:
> From: Chris Zhong <zyw@rock-chips.com>
>
> We may support training outside firmware, so we need support
> dpcd read/write to get the message or do some setting with
> display.
>
> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> Reviewed-by: Sean Paul <seanpaul@chromium.org>
> Reviewed-by: Enric Balletbo <enric.balletbo@collabora.com>
> @@ -1030,6 +1064,13 @@ static int cdn_dp_bind(struct device *dev, struct
> device *master, void *data) dp->active = false;
> dp->active_port = -1;
> dp->fw_loaded = false;
> + dp->aux.name = "DP-AUX";
> + dp->aux.transfer = cdn_dp_aux_transfer;
> + dp->aux.dev = dev;
> +
> + ret = drm_dp_aux_register(&dp->aux);
> + if (ret)
> + return ret;
this is missing matching drm_dp_aux_unregister calls both in the error path as
well as in the unbind callback.
With the code as is, the kernel gives warnings about it trying to initialize
an already initialized object ... in cases like probe-deferrals.
Heiko
prev parent reply other threads:[~2018-06-05 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 7:42 [PATCH v7 1/5] drm/rockchip: add transfer function for cdn-dp Lin Huang
2018-05-23 7:42 ` [PATCH v7 2/5] Documentation: dt-bindings: phy: add phy_config for Rockchip USB Type-C PHY Lin Huang
2018-05-23 7:42 ` [PATCH v7 3/5] soc: rockchip: split rockchip_typec_phy struct to separate header Lin Huang
2018-05-23 8:48 ` Enric Balletbo Serra
2018-05-23 7:42 ` [PATCH v7 4/5] phy: rockchip-typec: support variable phy config value Lin Huang
2018-05-23 8:50 ` Enric Balletbo Serra
2018-05-23 7:42 ` [PATCH v7 5/5] drm/rockchip: support dp training outside dp firmware Lin Huang
2018-05-23 8:50 ` Enric Balletbo Serra
2018-06-05 13:42 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2246202.0LhvmkcTbg@diego \
--to=heiko@sntech.de \
--cc=airlied@linux.ie \
--cc=briannorris@chromium.org \
--cc=daniel.vetter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eballetbo@gmail.com \
--cc=hl@rock-chips.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).