From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>
Cc: bhumirks@gmail.com, kernel-janitors@vger.kernel.org,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] thermal: exynos: constify thermal_zone_of_device_ops structures
Date: Mon, 07 Aug 2017 17:21:26 +0200 [thread overview]
Message-ID: <2246245.2R0fntX3Po@amdc3058> (raw)
In-Reply-To: <1501965437-30730-4-git-send-email-Julia.Lawall@lip6.fr>
On Saturday, August 05, 2017 10:37:16 PM Julia Lawall wrote:
> The thermal_zone_of_device_ops structure is only passed as the fourth
> argument to thermal_zone_of_sensor_register, which is declared as const.
> Thus the thermal_zone_of_device_ops structure itself can be const.
>
> Done with the help of Coccinelle.
>
> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct thermal_zone_of_device_ops i@p = { ... };
>
> @ok1@
> identifier r.i;
> expression e1,e2,e3;
> position p;
> @@
> thermal_zone_of_sensor_register(e1,e2,e3,&i@p)
>
> @bad@
> position p != {r.p,ok1.p};
> identifier r.i;
> struct thermal_zone_of_device_ops e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
> struct thermal_zone_of_device_ops i = { ... };
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Eduardo/Zhang, Please queue this patch for upstream, thanks!
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2017-08-07 15:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-05 20:37 [PATCH 0/4] constify thermal_zone_of_device_ops structures Julia Lawall
2017-08-05 20:37 ` [PATCH 1/4] thermal: qoriq: " Julia Lawall
2017-08-05 20:37 ` [PATCH 2/4] thermal: zx2967: " Julia Lawall
2017-08-05 20:37 ` [PATCH 3/4] thermal: exynos: " Julia Lawall
2017-08-07 15:21 ` Bartlomiej Zolnierkiewicz [this message]
2017-08-05 20:37 ` [PATCH 4/4] thermal: bcm2835: " Julia Lawall
2017-08-07 6:41 ` Stefan Wahren
2017-08-08 13:43 ` [PATCH 0/4] " Zhang Rui
2017-08-08 13:46 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2246245.2R0fntX3Po@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=Julia.Lawall@lip6.fr \
--cc=bhumirks@gmail.com \
--cc=edubezval@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).