From: John Crispin <john@phrozen.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Ralf Baechle <ralf@linux-mips.org>
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Lantiq: fix build failure
Date: Fri, 17 Jun 2016 10:46:43 +0200 [thread overview]
Message-ID: <224d637f-70b6-f8cc-0c68-c3e51d538906@phrozen.org> (raw)
In-Reply-To: <1466109968-22033-1-git-send-email-sudipm.mukherjee@gmail.com>
On 16/06/2016 22:46, Sudip Mukherjee wrote:
> Some configs of mips like xway_defconffig are failing with the error:
> arch/mips/lantiq/irq.c:209:2: error: initialization from incompatible
> pointer type [-Werror]
> "icu",
> ^
> arch/mips/lantiq/irq.c:209:2: error: (near initialization for
> 'ltq_irq_type.parent_device') [-Werror]
> arch/mips/lantiq/irq.c:219:2: error: initialization from incompatible
> pointer type [-Werror]
> "eiu",
> ^
> arch/mips/lantiq/irq.c:219:2: error: (near initialization for
> 'ltq_eiu_type.parent_device') [-Werror]
>
> The first member of the "struct irq" is no longer a pointer for the
> name.
>
> Fixes: be45beb2df69 ("genirq: Add runtime power management support for IRQ chips")
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Acked-by: John Crispin <john@phrozen.org>
> ---
>
> build log can be seen at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/137992701
>
> arch/mips/lantiq/irq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/lantiq/irq.c b/arch/mips/lantiq/irq.c
> index ff17669e..02c0252 100644
> --- a/arch/mips/lantiq/irq.c
> +++ b/arch/mips/lantiq/irq.c
> @@ -206,7 +206,7 @@ static void ltq_shutdown_eiu_irq(struct irq_data *d)
> }
>
> static struct irq_chip ltq_irq_type = {
> - "icu",
> + .name = "icu",
> .irq_enable = ltq_enable_irq,
> .irq_disable = ltq_disable_irq,
> .irq_unmask = ltq_enable_irq,
> @@ -216,7 +216,7 @@ static struct irq_chip ltq_irq_type = {
> };
>
> static struct irq_chip ltq_eiu_type = {
> - "eiu",
> + .name = "eiu",
> .irq_startup = ltq_startup_eiu_irq,
> .irq_shutdown = ltq_shutdown_eiu_irq,
> .irq_enable = ltq_enable_irq,
>
prev parent reply other threads:[~2016-06-17 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 20:46 [PATCH] MIPS: Lantiq: fix build failure Sudip Mukherjee
2016-06-17 8:46 ` John Crispin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=224d637f-70b6-f8cc-0c68-c3e51d538906@phrozen.org \
--to=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).