From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Chris von Recklinghausen <crecklin@redhat.com>,
ardb@kernel.org, simo@redhat.com, rafael@kernel.org,
decui@microsoft.com, linux-pm@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] use crc32 instead of md5 for hibernation e820 integrity check
Date: Thu, 1 Apr 2021 20:47:21 +0200 [thread overview]
Message-ID: <22595ae7-2ab5-2e6b-01d7-6b284dc8b0c2@csgroup.eu> (raw)
In-Reply-To: <20210401122458.12663-1-crecklin@redhat.com>
Le 01/04/2021 à 14:24, Chris von Recklinghausen a écrit :
> Currently, suspend on x86_64 fails when FIPS mode is enabled because it uses md5
> to generate a digest of the e820 region. MD5 is not FIPS compliant so an error
> is reported and the suspend fails.
>
> MD5 is used only to create a digest to ensure integrity of the region, no actual
> encryption is done. This patch set changes the integrity check to use crc32
> instead of md5 since crc32 is available in both FIPS and non-FIPS modes.
Why not put all those explanations in the patch itself ?
Because text in the cover is lost, so a cover is not really usefull for a single patch.
>
> Chris von Recklinghausen (1):
> use crc32 instead of md5 for hibernation image integrity check
>
> arch/x86/power/hibernate.c | 31 +++++++++++++++++--------------
> 1 file changed, 17 insertions(+), 14 deletions(-)
>
prev parent reply other threads:[~2021-04-01 18:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 12:24 [PATCH 0/1] use crc32 instead of md5 for hibernation e820 integrity check Chris von Recklinghausen
2021-04-01 12:24 ` [PATCH 1/1] " Chris von Recklinghausen
2021-04-01 13:34 ` Rafael J. Wysocki
2021-04-01 13:59 ` Ard Biesheuvel
2021-04-01 16:19 ` Rafael J. Wysocki
2021-04-01 18:43 ` Eric Biggers
2021-04-01 16:22 ` Rafael J. Wysocki
2021-04-01 18:47 ` Christophe Leroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22595ae7-2ab5-2e6b-01d7-6b284dc8b0c2@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=ardb@kernel.org \
--cc=crecklin@redhat.com \
--cc=decui@microsoft.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=simo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).