From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20508C433FE for ; Wed, 19 Oct 2022 14:21:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233569AbiJSOVj (ORCPT ); Wed, 19 Oct 2022 10:21:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233166AbiJSOVN (ORCPT ); Wed, 19 Oct 2022 10:21:13 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22305B1DE3 for ; Wed, 19 Oct 2022 07:04:51 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id r14so25431704edc.7 for ; Wed, 19 Oct 2022 07:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=w5+gyODwoHFKNypGT6uh/ysXTrRRHFbyILu1kotDzM4=; b=ZZrpWJr0JokM3BK2PpwWz7MaqS/A7K1EC66XS8ZizSz4zzmpa+PCvXIKtltBzs/reZ sVxov/MPI1hg5hu1I4N3B7mre2Ac8Q65gCcYCGT1pjRRu6G/5ULnx1msljvsp4+Ui4Va ZVumpBC5+ZAtg7DpovO1Xs7RCRcOqeiqxmPcYyZ8QhxOPZRmH8N99FG3CiaHbdyc/SkX ENnedz5T0tuARHVKT4qND9XHLrMMVz5tWH1u+WMU4PmQn2oWZT9AkgcMSZvPRbR9VQtq 44rvFZk4AlKfaijtdvuEfVmcMJm21smZqNUbFbmDOisSk33aNfDbqzvOQyLVfEgwLSmK aZYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w5+gyODwoHFKNypGT6uh/ysXTrRRHFbyILu1kotDzM4=; b=YCvlfoXZ/9dfSfSOUuQ5yYM/nmzEsLLI6objqsip1O2ooZjyfPq0Xxek4SSlUqSFJh BJrNlSML+NdjNlxLW23lXhS1dR24lVMdNjuBElmTb6iqpyVI/iMfgsZCLqRstDFpt5Ac r6XLcjmxski/1C9oQxfZxNa8ObC/ve25c0Xn57nJtiMR4lDaZ37T0BXgMEAXwllf6xRN f/UjyV05chEarKfe7FnKfVKqLGZVTqrMgS/eP4+IzOr2IYrnSZUc3kdy6ZH5+DWDmmOj XYhaG+0IYcCQfEaitKtyCrsAahRwlFC3R3ARK4L8/ZqqfHIs4fsYXZClsMET9/KyYRtb EYDQ== X-Gm-Message-State: ACrzQf1st7f4psK88R25pEFwFnXrWczXuqO/aSmBIJlkJxRfPmmN/kex CzQcRDKtkohUMPEdIeIZgztO4BmWvlqiaw== X-Google-Smtp-Source: AMsMyM6Wz4e6pH5YTXalvM3jqNkmWpZ+07QEhZ29oRNNSkpxIXajymXLgZHoHSMNHYwLDMt5DvO4bQ== X-Received: by 2002:a2e:a602:0:b0:264:5132:f59 with SMTP id v2-20020a2ea602000000b0026451320f59mr3065213ljp.0.1666187513443; Wed, 19 Oct 2022 06:51:53 -0700 (PDT) Received: from [10.10.15.130] ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id l29-20020ac2555d000000b00498fd423cc3sm2288264lfk.295.2022.10.19.06.51.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Oct 2022 06:51:53 -0700 (PDT) Message-ID: <22640161-0b28-d91c-5af8-ca9fa36954f1@linaro.org> Date: Wed, 19 Oct 2022 16:51:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v2 12/15] phy: qcom-qmp-pcie: fix initialisation reset Content-Language: en-GB To: Johan Hovold , Vinod Koul Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221019113552.22353-1-johan+linaro@kernel.org> <20221019113552.22353-13-johan+linaro@kernel.org> From: Dmitry Baryshkov In-Reply-To: <20221019113552.22353-13-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/10/2022 14:35, Johan Hovold wrote: > Add the missing delay after asserting reset. This is specifically needed > for the reset to have any effect on SC8280XP. > > The vendor driver uses a 1 ms delay, but that seems a bit excessive. > Instead use a 200 us delay which appears to be more than enough and also > matches the UFS reset delay added by commit 870b1279c7a0 ("scsi: > ufs-qcom: Add reset control support for host controller"). > > Signed-off-by: Johan Hovold > --- > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry