linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Igor Russkikh <irusskikh@marvell.com>
To: David Miller <davem@davemloft.net>,
	Alexander Lobakin <alobakin@marvell.com>
Cc: <kai.heng.feng@canonical.com>, <anthony.wong@canonical.com>,
	<kuba@kernel.org>, Nikita Danilov <ndanilov@marvell.com>,
	Mark Starovoytov <mstarovoitov@marvell.com>,
	Dmitry Bezrukov <dbezrukov@marvell.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH] net: atlantic: Add support for firmware v4
Date: Wed, 15 Jul 2020 18:34:31 +0300	[thread overview]
Message-ID: <226601b2-562c-ae59-ee0d-51b130255c18@marvell.com> (raw)
In-Reply-To: <20200707.125624.2030141794702878802.davem@davemloft.net>


>>> We have a new ethernet card that is supported by the atlantic driver:
>>> 01:00.0 Ethernet controller [0200]: Aquantia Corp. AQC107 NBase-T/IEEE
> 802.3bz Ethernet Controller [AQtion] [1d6a:07b1] (rev 02)
>>>
>>> But the driver failed to probe the device:
>>> kernel: atlantic: Bad FW version detected: 400001e
>>> kernel: atlantic: probe of 0000:01:00.0 failed with error -95
>>>
>>> As a pure guesswork, simply adding the firmware version to the driver
>>
>> Please don't send "pure guessworks" to net-fixes tree. You should have
>> reported this as a bug to LKML and/or atlantic team, so we could issue
>> it.
> 
> Production hardware is shipping to customers and the driver
> maintainers didn't add support for this ID yet?  What is that
> "atlantic team" waiting for?
> 
> Honestly I don't blame someone for posting a patch like this to get it
> to work.

Me too ;)

We've discussed this with Kai Heng internally, that was really an engineering
sample.

We'll repost this patch soon with some more changes required for that new FW.

Thanks,
  Igor

      reply	other threads:[~2020-07-15 15:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07  6:38 [PATCH] net: atlantic: Add support for firmware v4 Kai-Heng Feng
2020-07-07  8:46 ` Alexander Lobakin
2020-07-07 10:02   ` Kai-Heng Feng
2020-07-07 19:56   ` David Miller
2020-07-15 15:34     ` Igor Russkikh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=226601b2-562c-ae59-ee0d-51b130255c18@marvell.com \
    --to=irusskikh@marvell.com \
    --cc=alobakin@marvell.com \
    --cc=anthony.wong@canonical.com \
    --cc=davem@davemloft.net \
    --cc=dbezrukov@marvell.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mstarovoitov@marvell.com \
    --cc=ndanilov@marvell.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).