archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <>
To: Hans de Goede <>
Cc: Linus Torvalds <>,
	Linux Kernel Mailing <>,
	Benjamin Tissoires <>,
	Jiri Kosina <>,
Subject: Strange regression in hid_llogitech_dj (was: Re: Linux 5.2-rc4)
Date: Tue, 11 Jun 2019 23:53:20 +0200	[thread overview]
Message-ID: <2268131.Lc39eCoc3j@kreacher> (raw)
In-Reply-To: <>

On Sunday, June 9, 2019 5:46:48 AM CEST Linus Torvalds wrote:
> No, I'm not confused, and I haven't lost track of what day it is, I do
> actually know that it's still Saturday here, not Sunday, and I'm just
> doing rc4 a bit early because I'll be on an airplane during my normal
> release time. And while I've done releases on airports and airplanes
> before, I looked at my empty queue of pull requests and went "let's
> just do it now".
> We've had a fairly calm release so far, and on the whole that seems to
> hold. rc4 isn't smaller than rc3 was (it's a bit bigger), but rc3 was
> fairly small, so the size increase isn't all that worrisome. I do hope
> that we'll start actually shrinking now, though.

I noticed that the cordless mouse used by me with one of the machines here
stopped to work in 5.2-rc (up to and including the -rc4).

Bisection turned up commit 74808f9115ce ("HID: logitech-dj: add support for non
unifying receivers").

Of course, that commit does not revert cleanly from 5.2-rc4, but I have reverted
the changes made by it in hid/hid-ids.h and I took the version of hid/hid-logitech-dj.c
from commit b6aeeddef68d ("HID: logitech-dj: add logi_dj_recv_queue_unknown_work
helper"), which is the parent of commit 74808f9115ce, and that made the mouse
work again for me.

Here's the output of "dmesg | grep -i logitech" from 5.2-rc4 with the above changes:

[    4.288905] usb 1-2: Manufacturer: Logitech
[    5.444621] input: Logitech USB Receiver as /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.0/0003:046D:C52F.0002/input/input23
[    5.446960] hid-generic 0003:046D:C52F.0002: input,hidraw1: USB HID v1.11 Mouse [Logitech USB Receiver] on usb-0000:00:14.0-2/input0
[    5.451265] input: Logitech USB Receiver Consumer Control as /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.1/0003:046D:C52F.0003/input/input24
[    5.507545] hid-generic 0003:046D:C52F.0003: input,hiddev96,hidraw2: USB HID v1.11 Device [Logitech USB Receiver] on usb-0000:00:14.0-2/input1

Please let me know what you need to diagnose this.


  parent reply	other threads:[~2019-06-11 21:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-09  3:46 Linux 5.2-rc4 Linus Torvalds
2019-06-09  8:15 ` Bhaskar Chowdhury
2019-06-11 21:53 ` Rafael J. Wysocki [this message]
2019-06-11 22:02   ` Strange regression in hid_llogitech_dj (was: Re: Linux 5.2-rc4) Jiri Kosina
2019-06-12  8:24     ` Rafael J. Wysocki
2019-06-12  8:31       ` Jiri Kosina
2019-06-12  8:51         ` Rafael J. Wysocki
2019-06-12  9:24           ` Jiri Kosina
2019-07-25 10:07 ` [Regression] 5.3-rc1: hid_llogitech_dj does not work Rafael J. Wysocki
2019-07-25 15:50   ` Hans de Goede
2019-07-29 15:49     ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2268131.Lc39eCoc3j@kreacher \ \ \ \ \ \ \ \
    --subject='Strange regression in hid_llogitech_dj (was: Re: Linux 5.2-rc4)' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).