From: Randy Dunlap <rdunlap@infradead.org>
To: Matthew Wilcox <willy@infradead.org>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
linux-mm@kvack.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP
Date: Tue, 21 Mar 2023 09:43:04 -0700 [thread overview]
Message-ID: <227fdc99-b54a-eeb0-c4e6-21ed92731240@infradead.org> (raw)
In-Reply-To: <ZBneELQuakjva1xa@casper.infradead.org>
On 3/21/23 09:40, Matthew Wilcox wrote:
> On Tue, Mar 21, 2023 at 09:30:59AM +0100, Geert Uytterhoeven wrote:
>> -#if (defined(CONFIG_NUMA) && defined(CONFIG_MEMORY_HOTPLUG)) || defined(CONFIG_SMP)
>> +#if defined(CONFIG_NUMA) || defined(CONFIG_SMP)
>
> I'm amused by the thought of CONFIG_NUMA without CONFIG_SMP.
> Is it possible to have one node with memory and a single CPU, then
> another node with memory and no CPU?
More likely 1 with CPU+memory, 1 with memory only.
I've been told that that are also I/O-only nodes.
--
~Randy
next prev parent reply other threads:[~2023-03-21 16:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 8:30 [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP Geert Uytterhoeven
2023-03-21 8:41 ` John Paul Adrian Glaubitz
2023-03-21 8:50 ` Geert Uytterhoeven
2023-03-21 15:07 ` Vlastimil Babka
2023-03-21 15:29 ` Randy Dunlap
2023-03-21 16:40 ` Matthew Wilcox
2023-03-21 16:43 ` Randy Dunlap [this message]
2023-03-22 16:16 ` Dave Hansen
2023-03-22 16:46 ` Matthew Wilcox
2023-03-22 16:49 ` Dave Hansen
2023-03-23 8:25 ` Geert Uytterhoeven
2023-03-23 8:28 ` John Paul Adrian Glaubitz
2023-03-23 8:36 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=227fdc99-b54a-eeb0-c4e6-21ed92731240@infradead.org \
--to=rdunlap@infradead.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=cl@linux.com \
--cc=dave.hansen@linux.intel.com \
--cc=geert+renesas@glider.be \
--cc=glaubitz@physik.fu-berlin.de \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sh@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).