Re: [PATCH] io_uring: Add to traces the req pointer when available

From: Olivier Langlois <olivier@trillion01.com>
To: Stefan Metzmacher <metze@samba.org>,
	Pavel Begunkov <asml.silence@gmail.com>,
	Jens Axboe <axboe@kernel.dk>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring: Add to traces the req pointer when available
Date: Wed, 26 May 2021 13:19:27 -0400	[thread overview]
Message-ID: <2285bf713be951917f9bec40f9cc45045990cc71.camel@trillion01.com> (raw)
In-Reply-To: <9505850ae4c203f6b8f056265eddbffaae501806.camel@trillion01.com>

On Wed, 2021-05-26 at 12:18 -0400, Olivier Langlois wrote:
> > 
> > If that gets changed, could be also include the personality id and
> > flags here,
> > and maybe also translated the opcode and flags to human readable
> > strings?
> > 
> If Jens and Pavel agrees that they would like to see this info in the
> traces, I have no objection adding it.
> 
I need to learn to think longer before replying...

opcode in readable string:
If Jens and Pavel agrees to it, easy to add

flags:
You have my support that it is indeed a very useful info to have in the
submit_sqe trace when debugging with traces

flags in readable string:
After thinking about it, I wouldn't do it. Converting a bitmask of
flags into a string isn't that complex but it isn't trivial neither.
This certainly adds a maintenance burden every time the flags would be
updated. I wouldn't want that burden on my shoulders.