From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 658D7C4332D for ; Fri, 20 Mar 2020 15:57:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 327FA20709 for ; Fri, 20 Mar 2020 15:57:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727134AbgCTP52 (ORCPT ); Fri, 20 Mar 2020 11:57:28 -0400 Received: from ivanoab7.miniserver.com ([37.128.132.42]:59610 "EHLO www.kot-begemot.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbgCTP51 (ORCPT ); Fri, 20 Mar 2020 11:57:27 -0400 Received: from tun252.jain.kot-begemot.co.uk ([192.168.18.6] helo=jain.kot-begemot.co.uk) by www.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jFK1T-0005Zf-3d; Fri, 20 Mar 2020 15:57:23 +0000 Received: from jain.kot-begemot.co.uk ([192.168.3.3]) by jain.kot-begemot.co.uk with esmtp (Exim 4.92) (envelope-from ) id 1jFK1Q-0003GD-J5; Fri, 20 Mar 2020 15:57:22 +0000 Subject: Re: [PATCH] arch/um: falloc.h needs to be directly included for older libc To: Alan Maguire , jdike@addtoit.com, richard@nod.at, alex.dewar@gmx.co.uk, erelx.geron@intel.com, johannes.berg@intel.com, arnd@arndb.de, linux-um@lists.infradead.org Cc: brendanhiggins@google.com, linux-kernel@vger.kernel.org References: <1584466534-13248-1-git-send-email-alan.maguire@oracle.com> From: Anton Ivanov Message-ID: <2295c218-74a6-d785-f4b1-2046ee91503a@cambridgegreys.com> Date: Fri, 20 Mar 2020 15:57:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <1584466534-13248-1-git-send-email-alan.maguire@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Clacks-Overhead: GNU Terry Pratchett Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/03/2020 17:35, Alan Maguire wrote: > When building UML with glibc 2.17 installed, compilation > of arch/um/os-Linux/file.c fails due to failure to find > FALLOC_FL_PUNCH_HOLE and FALLOC_FL_KEEP_SIZE definitions. > > It appears that /usr/include/bits/fcntl-linux.h (indirectly > included by /usr/include/fcntl.h) does not include falloc.h > with an older glibc, whereas a more up-to-date version > does. > > Adding the direct include to file.c resolves the issue > and does not cause problems for more recent glibc. > > Fixes: 50109b5a03b4 ("um: Add support for DISCARD in the UBD Driver") > Cc: Brendan Higgins > Signed-off-by: Alan Maguire > --- > arch/um/os-Linux/file.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/um/os-Linux/file.c b/arch/um/os-Linux/file.c > index fbda105..5c819f8 100644 > --- a/arch/um/os-Linux/file.c > +++ b/arch/um/os-Linux/file.c > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > #include > #include > #include > Acked-By: Anton Ivanov -- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/