From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757343AbdACN0W convert rfc822-to-8bit (ORCPT ); Tue, 3 Jan 2017 08:26:22 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:50977 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757318AbdACNYv (ORCPT ); Tue, 3 Jan 2017 08:24:51 -0500 From: Arnd Bergmann To: Greentime Hu Cc: Florian Fainelli , netdev , devicetree@vger.kernel.org, Andrew Lunn , linux-kernel@vger.kernel.org, Jiri Pirko Subject: Re: [PATCH v3] net: ethernet: faraday: To support device tree usage. Date: Tue, 03 Jan 2017 14:24:35 +0100 Message-ID: <2299808.LHnPolcyRJ@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1483083470-15779-1-git-send-email-green.hu@gmail.com> <6434425.l4ZxB6kK6L@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K0:sDxNEHWSk172kl5U9x5q6560AHkiJR5amu6EjyDtguYbMVuY9Zw vJpcxdRqDQNbM96wGcGc+QM8cKYAxHr5fbFz/MVMh87UfQu5Ca8u5G+cQkymmVy3l2Hoejt x3cUrqOJw+Gn35IT6EiOqjqB9cKTap8NUFwiM6hhQP+L0aZefPRkvLj4P/eUkZZeIA4NIeQ 1V1fqzSRsx14MWKBHvVXA== X-UI-Out-Filterresults: notjunk:1;V01:K0:TCB/aMshZk0=:1cD4ubMem4sjwEu326rmsS eJ7Z4612W0aBca1djfKGdyK6ILdk1P/zlV/ugJcPaWkM8IlEkBP0I1fe0tFVqnE1Z4frISN7R aMqEesln4xlackh+aBAqAzVbPWNGrUXkHwWlyqbXwATEDHKAli++ibSE6/aubjT8A2zY91NfW WosMVKoKPdrPQM7nMCMB0xuhCb74ZLBhp7OWD8/dsu7CFxUFdG8q0FX0jn/HhYCRfkFiQlSXh LizxVu2FEBH5NxCtnPSgVDXzTfRzg+j7+gpTwfZhj8HsjFDdiV+1FDbwgs363+NARC0AvsITI UhRLyYTArsS9tVvTNj4bqqQDp72IiHI2cFXwlqzklqLFA/Z9h4G/BpH61nLaqyufcUARkyOK9 b8KPXuQyZ55Z8i7lZKnMGD3KAuP2kn+TcDd8OyYIHaQW4kgJhQA5MxixyeDj+xkyXfSxN8Oxh TCpFae8R0RP7IQ5d/AQwcZFuK1vr43SMtbFp1meOR1KqSGZJ7InCOsjBj60teFb8w+j918XWa fwHamr7Ouphl3AHKhCTlhOC8oY9GBhtiZ7uldqpOV5o8vGLoB7qa3yzUiMfaupnzVlfPzycVK e0ndyKobm7nU0kZRYDM+trs1r7zSdgc9b2E59dgaTSrwTEJS0z5ZBv8jxK2ySLUE0s7PPk+br kyW6anMPpU0/YZa5aW8Uxpa4NO5h4umO4uhKKRYJntBUJ4C7M2UOShMg8/PG0JJ5ZLSaM/vAB 19vLINMtZNDmF1ea Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, January 3, 2017 2:05:47 PM CET Greentime Hu wrote: > ​I am not sure if atmac and moxa-art are exactly hardware compatible though > they are based on faraday ftmac. > It may be better if we use 2 different device tree binding documents to > describe for these 2 different drivers to use. They are probably slightly different, but close enough to have the same binding document, as there is no technical reason to have two separate drivers for them. The binding should be about the hardware type, not the way that Linux currently implements the drivers. Arnd