From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753331AbbKAXHq (ORCPT ); Sun, 1 Nov 2015 18:07:46 -0500 Received: from mta02.ornl.gov ([128.219.177.12]:41340 "EHLO mta02.ornl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753087AbbKAXHp convert rfc822-to-8bit (ORCPT ); Sun, 1 Nov 2015 18:07:45 -0500 X-SG: RELAYLIST X-IronPort-AV: E=Sophos;i="5.20,230,1444708800"; d="scan'208";a="91332621" From: "Simmons, James A." To: "'Greg Kroah-Hartman'" , James Simmons CC: "devel@driverdev.osuosl.org" , Oleg Drokin , Linux Kernel Mailing List , "lustre-devel@lists.lustre.org" Subject: RE: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c Thread-Topic: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c Thread-Index: AQHRE2b5NQdS+sL+a0qnSMwqJI2hqJ6HzBew Date: Sun, 1 Nov 2015 23:07:42 +0000 Message-ID: <229dae23c2f34950a21db4bd6dbdcfba@EXCHCS32.ornl.gov> References: <1446161303-798-1-git-send-email-jsimmons@infradead.org> <1446161303-798-2-git-send-email-jsimmons@infradead.org> <20151030230148.GB2920@kroah.com> In-Reply-To: <20151030230148.GB2920@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [128.219.12.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >On Thu, Oct 29, 2015 at 07:28:21PM -0400, James Simmons wrote: >> With nidstring now having the latest fixes we can >> now clean up all the remaining checkpatch errors >> for nidstring.c. > >Please be specific as to exactly what you changed, and break it up into >one-patch-per-thing. And no, "fix all checkpatch errors" is not "one >thing" Hmm. This makes me think I might be going about this wrong. Instead of doing style changes per file I should be doing one style change per subsystem instead. Unless you prefer doing these style changes on per file base. Perhaps for now I should focus on pushing the fixes that have cumulated and once caught up then finished off the style issues.