From: Bean Huo <huobean@gmail.com>
To: Avri Altman <Avri.Altman@wdc.com>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
"agross@kernel.org" <agross@kernel.org>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"subhashj@codeaurora.org" <subhashj@codeaurora.org>,
"venkatg@codeaurora.org" <venkatg@codeaurora.org>
Cc: "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: ufs-qcom: Fix scheduling while atomic issue
Date: Tue, 26 May 2020 11:41:52 +0200 [thread overview]
Message-ID: <229fb4b001341c536f5996151ec6d78e925ecda4.camel@gmail.com> (raw)
In-Reply-To: <SN6PR04MB4640A91499223A26A7460738FCB00@SN6PR04MB4640.namprd04.prod.outlook.com>
On Tue, 2020-05-26 at 06:25 +0000, Avri Altman wrote:
>
> > ufs_qcom_dump_dbg_regs() uses usleep_range, a sleeping function,
> > but can
> > be called from atomic context in the following flow:
> >
> > ufshcd_intr -> ufshcd_sl_intr -> ufshcd_check_errors ->
> > ufshcd_print_host_regs -> ufshcd_vops_dbg_register_dump ->
> > ufs_qcom_dump_dbg_regs
> >
> > This causes a boot crash on the Lenovo Miix 630 when the interrupt
> > is
> > handled on the idle thread.
> >
> > Fix the issue by switching to udelay().
> >
> > Fixes: 9c46b8676271 ("scsi: ufs-qcom: dump additional testbus
> > registers")
> > Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
>
> Reviewed-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Bean Huo <beanhuo@micron.com>
next prev parent reply other threads:[~2020-05-26 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 20:41 [PATCH] scsi: ufs-qcom: Fix scheduling while atomic issue Jeffrey Hugo
2020-05-26 6:25 ` Avri Altman
2020-05-26 9:41 ` Bean Huo [this message]
2020-05-27 2:12 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=229fb4b001341c536f5996151ec6d78e925ecda4.camel@gmail.com \
--to=huobean@gmail.com \
--cc=Avri.Altman@wdc.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=subhashj@codeaurora.org \
--cc=venkatg@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).