From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751292AbdAWRFT (ORCPT ); Mon, 23 Jan 2017 12:05:19 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:37487 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbdAWRFR (ORCPT ); Mon, 23 Jan 2017 12:05:17 -0500 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCHSET v4] blk-mq-scheduling framework From: Paolo Valente In-Reply-To: <59b134de-5d2d-5f16-3118-bdc16bc6e36b@fb.com> Date: Mon, 23 Jan 2017 18:04:31 +0100 Cc: Jens Axboe , linux-block@vger.kernel.org, Linux-Kernal , Omar Sandoval , Linus Walleij , Ulf Hansson , Mark Brown Message-Id: <22EDFDE7-71FF-4265-8DDE-B141D3FD26B2@linaro.org> References: <1481933536-12844-1-git-send-email-axboe@fb.com> <7A8A5078-E9B8-4EBF-BAB1-9E8EEBF3A043@linaro.org> <37570439-97C8-4009-B143-C5E78789A137@linaro.org> <2028A64C-40E5-403D-B5E9-05863E94B4C5@linaro.org> <59b134de-5d2d-5f16-3118-bdc16bc6e36b@fb.com> To: Jens Axboe X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0NH5OMV003881 > Il giorno 18 gen 2017, alle ore 17:21, Jens Axboe ha scritto: > > On 01/18/2017 08:14 AM, Paolo Valente wrote: >> according to the function blk_mq_sched_put_request, the >> mq.completed_request hook seems to always be invoked (if set) for a >> request for which the mq.put_rq_priv is invoked (if set). > > Correct, any request that came out of blk_mq_sched_get_request() > will always have completed called on it, regardless of whether it > had IO started on it or not. > It seems that some request, after being dispatched, happens to have no mq.put_rq_priv invoked on it now or then. Is it expected? If it is, could you point me to the path through which the end of the life of such a request is handled? Thanks, Paolo > -- > Jens Axboe >