From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1296C433EF for ; Thu, 9 Jun 2022 17:12:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344478AbiFIRMf (ORCPT ); Thu, 9 Jun 2022 13:12:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230002AbiFIRMd (ORCPT ); Thu, 9 Jun 2022 13:12:33 -0400 Received: from smtp-190b.mail.infomaniak.ch (smtp-190b.mail.infomaniak.ch [IPv6:2001:1600:3:17::190b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2440C20AA79 for ; Thu, 9 Jun 2022 10:12:32 -0700 (PDT) Received: from smtp-3-0001.mail.infomaniak.ch (unknown [10.4.36.108]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4LJrHy41nxzMqHBW; Thu, 9 Jun 2022 19:12:30 +0200 (CEST) Received: from ns3096276.ip-94-23-54.eu (unknown [23.97.221.149]) by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4LJrHx72dwzlmMv4; Thu, 9 Jun 2022 19:12:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1654794750; bh=2M0p8j1YB8Vaadx3dL5PEu4PAcNlmdFXJTXC8kWcu5A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ta5ituWDadhYZ7PdVU7fL24nRsCvv5LKzMv/yp7i+QgAOJO5hHrwTV2qnsQqePNGN Ej05c4SY4B5W1Epa8SR+FNKIpvr/CWzPYnaGcFHq3urnJwWLwmJwPIIJB2mAxXMOye iDZ0mFBXLBUNmon+NboNyJKPaUcqacLwfspWSabw= Message-ID: <22a067fe-795f-d3ae-fac6-7baa75393349@digikod.net> Date: Thu, 9 Jun 2022 19:12:29 +0200 MIME-Version: 1.0 User-Agent: Subject: Re: [PATCH] certs: Convert spaces in certs/Makefile to a tab Content-Language: en-US To: Masahiro Yamada , David Howells Cc: Linus Torvalds , Jarkko Sakkinen , keyrings@vger.kernel.org, Linux Kbuild mailing list , Linux Kernel Mailing List References: <165451871967.1941436.17828809503267245815.stgit@warthog.procyon.org.uk> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2022 18:49, Masahiro Yamada wrote: > On Mon, Jun 6, 2022 at 9:32 PM David Howells wrote: >> >> There's a rule in certs/Makefile for which the command begins with eight >> spaces. This results in: >> >> ../certs/Makefile:21: FORCE prerequisite is missing >> ../certs/Makefile:21: *** missing separator. Stop. >> >> Fix this by turning the spaces into a tab. >> >> Fixes: addf466389d9 ("certs: Check that builtin blacklist hashes are valid") >> Signed-off-by: David Howells >> cc: Mickaël Salaün >> cc: Jarkko Sakkinen >> cc: keyrings@vger.kernel.org > > > Not only 8-space indentation, but also: > > - config_filename does not exist > - $(SYSTEM_BLACKLIST_HASH_LIST_SRCPREFIX) is always empty > - $(SYSTEM_BLACKLIST_HASH_LIST_FILENAME) is always empty These are imported helpers (not only used for this hash list BTW), hence not defined in this Makefile. > > >> --- >> >> certs/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/certs/Makefile b/certs/Makefile >> index bb904f90f139..cb1a9da3fc58 100644 >> --- a/certs/Makefile >> +++ b/certs/Makefile >> @@ -18,7 +18,7 @@ CFLAGS_blacklist_hashes.o += -I$(srctree) >> >> targets += blacklist_hashes_checked >> $(obj)/blacklist_hashes_checked: $(SYSTEM_BLACKLIST_HASH_LIST_SRCPREFIX)$(SYSTEM_BLACKLIST_HASH_LIST_FILENAME) scripts/check-blacklist-hashes.awk FORCE >> - $(call if_changed,check_blacklist_hashes,$(SYSTEM_BLACKLIST_HASH_LIST_SRCPREFIX)$(CONFIG_SYSTEM_BLACKLIST_HASH_LIST)) >> + $(call if_changed,check_blacklist_hashes,$(SYSTEM_BLACKLIST_HASH_LIST_SRCPREFIX)$(CONFIG_SYSTEM_BLACKLIST_HASH_LIST)) >> obj-$(CONFIG_SYSTEM_BLACKLIST_KEYRING) += blacklist_hashes.o >> else >> obj-$(CONFIG_SYSTEM_BLACKLIST_KEYRING) += blacklist_nohashes.o >> >> > > > -- > Best Regards > Masahiro Yamada