From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762113AbcINMuw (ORCPT ); Wed, 14 Sep 2016 08:50:52 -0400 Received: from mx2.suse.de ([195.135.220.15]:55100 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756146AbcINMut (ORCPT ); Wed, 14 Sep 2016 08:50:49 -0400 Subject: Re: [PATCH 13/15] hisi_sas: remove init_id_frame_v1_hw() To: John Garry , jejb@linux.vnet.ibm.com, martin.petersen@oracle.com References: <1473176185-217808-1-git-send-email-john.garry@huawei.com> <1473176185-217808-14-git-send-email-john.garry@huawei.com> Cc: linuxarm@huawei.com, zhangfei.gao@linaro.org, xuwei5@hisilicon.com, john.garry2@mail.dcu.ie, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Xiang Chen From: Hannes Reinecke Message-ID: <22dd5b14-a843-9522-f609-f3a1be0a563c@suse.de> Date: Wed, 14 Sep 2016 14:50:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <1473176185-217808-14-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2016 05:36 PM, John Garry wrote: > Function config_id_frame_v1_hw() is called twice for > each PHY during initialisation, which is unneeded. > > So remove init_id_frame_v1_hw(), which only calls > config_id_frame_v1_hw(). > > We will keep the call to config_id_frame_v1_hw() > in start_phy_v1_hw() since it will be used for > PHY reset functions. > > Signed-off-by: John Garry > Signed-off-by: Xiang Chen > --- > drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 10 ---------- > 1 file changed, 10 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)