From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161856AbdDUQmQ (ORCPT ); Fri, 21 Apr 2017 12:42:16 -0400 Received: from mail-ve1eur01on0139.outbound.protection.outlook.com ([104.47.1.139]:54580 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1161812AbdDUQkF (ORCPT ); Fri, 21 Apr 2017 12:40:05 -0400 Authentication-Results: pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dmarc=none action=none header.from=axentia.se; Subject: Re: [PATCH v13 03/10] mux: minimal mux subsystem and gpio-based mux controller To: Philipp Zabel References: <1492101794-13444-1-git-send-email-peda@axentia.se> <1492101794-13444-4-git-send-email-peda@axentia.se> <1492784318.2364.8.camel@pengutronix.de> CC: , Greg Kroah-Hartman , Wolfram Sang , Rob Herring , Mark Rutland , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Corbet , , , , , Andrew Morton , Colin Ian King , Paul Gortmaker , From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <23158179-3667-c4d7-c8ac-b7a011d77749@axentia.se> Date: Fri, 21 Apr 2017 17:08:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1492784318.2364.8.camel@pengutronix.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [81.224.171.159] X-ClientProxiedBy: DB6PR07CA0171.eurprd07.prod.outlook.com (10.166.153.153) To DB6PR0202MB2551.eurprd02.prod.outlook.com (10.169.211.9) X-MS-Office365-Filtering-Correlation-Id: d5a99243-b192-4c5e-0c69-08d488c840a0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075);SRVR:DB6PR0202MB2551; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0202MB2551;3:yyu3YX+IrdHsXay0qexziOEZO/9vCGTpn93/mGATSHL9m/9YvBEsJLFO+PBB9ti2yVJzME3hksO2icrAeDTINovmr367uzzAEbz+eRNW9p+9/FjhtamngKoJeILoJ52ENa+1v8M0XErL/GV2G47kmVX/Hvh50998vLmO7I6BNT/RY0gkd9bIigiOPoE2tGmbJ49ggf3/sG6dAaUEl0YW54KhklGwk6bZK9pCg9onrreZvcNLILTbR+3PkUg/dWlK7E6vWD/AHnEIvCXqyY69RGKIGTEw7KxukUws7bwGXN0vPRCyNL9uUhGWt4upxAr8;25:+1uqTcltaiJ3mWb0nTdLu0EvuoCQ7bZuNI+iz8wGPd4VUzyguPTKinuIjIgf030BLr745mBH0t7148WfGBXlgoFVdWACstx/T1zuGAKNWeAKo9oYbqMYqrkRFVjjt1mOMdBHTa390I/ZmOSLlZ5fE9B766uni4hSUX7QM5c6sP/+BytW9Kc6Mev5iLHWsZ44TPTSux5Xf08wWCcfKinFt9j3COpyjGsHcUIEdYQqvqBujXESVECUGLjPXd8RSwKdpi2vKsCeUgGwc3iB5X80HQrmGsm55zysbqOx+Bub2ncXTLfl924M6Wr+pUjwkm866Ar4tJugawFisi+4zy/pXWa2hopVzRTjLu2G+4gTVqG9itmu2DMGWUfYqa3/3ZxL7muu75jED3VJFZo/k5tID/Zhm/OwYJVBb7+0V7cTuQO40NZM9TUDCmtLLqULiLXWAz8gX68KBxPxuNzkS7dPlQ== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0202MB2551;31:fiNfrX/210qWxqQGV+90Xkzx/PsxjpWE7korfYm+mofOWvsrWo4J9umsfHqAZQ7pi+Xj3PZT3zk8Ai1CaYfrAKAKd6wDSDNBR3Akmbs37dLK2GJ+LBLC+E0Vscu/ybX5yoyTXxpsizWDbMGW8SrFjtr7HYOJqLX2LFLU9WGMAaYi+UzHxBvXtX9WIjvlvZjx0OzEe3MLoeoYdKEbBJrkYl9XypaEJKNPwxeqqJvInlKIocJYNMW+fyshrKyFMUxtUuOTOEupSzK7ebeW2w6ahCtrw/H7ue92WcXwVoqoq+U= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123564025)(20161123560025)(20161123562025)(20161123555025)(2016111802025)(6043046)(6072148);SRVR:DB6PR0202MB2551;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0202MB2551; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0202MB2551;4:5gyixnJr5QD5893iN9WbwHWkwF3mQsHXJvnntg0ICyVWamGYwCU80+UvdtcCrojZWIkmuZrpkqfOckRpieeUdMIboJZyNsIeoDOR9ccnn0Bd0nwCzVAIiByshLGY8NJV9omtq++6AGu4TDO3+sI9WA4Gnti2iFKHhtUyptxmAbyYTjNCuOvIwUW1oy46BcbHJ31iRkJeQBWeWu+l4J8yyxrwN9dT6Pj0uXqw9Bsy7ceXRq/BPkB0ExlJMB06Q+vfKYcAh270gjBhsbvFczX8QETJDVXDbc/B6bD4eBIO4fJ45a94kW3v+vulI5JlclG63avIvV4DaN9jzvgG8AFtLmFI3v84cR+MArqb+huxHD77iLbzMQ1A63657gwsQH5OWDN5n26lYeB7uKC/OjtZHmSdc6r4bo2136EhKwlC8DYyAL8izI5ABjaltRra/G3eqvkdeqtttKwJfN46QXj28nKwEv8e3gTIKXwt/8oI/tOs2dJgl74KW79qG/M9vF5zXB9ZrMxBXCpHg51B+fZRJZ8QhwFv2Fvy/ynv4m528CSmsqleyFEnN3rwKPPcAiOGNqAjpQHeVV5G6HM7DBYSVILpgmaSk2TzygSfqB3o7DuzBiw2nSGIxYW5ne3hJTsNUpLwxY1sYCfxqsi34g9Sb3WENRf4cj6L0BMcIMmN4hJfN1zpVmFEZEI/Pi8UPgy0HGTqlLf+ERiSY/b6uBnHC/l8efKPcxqSb9Kq9mTycg60U5SA20w/MLkYK6P/Zcn2SoOYPiohz8e/nKcenoNJNQ== X-Forefront-PRVS: 02843AA9E0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39450400003)(39830400002)(39400400002)(39410400002)(24454002)(377424004)(3846002)(305945005)(7416002)(7736002)(2950100002)(6116002)(86362001)(5660300001)(2906002)(229853002)(6666003)(8676002)(81166006)(31686004)(33646002)(42186005)(54356999)(36756003)(50986999)(64126003)(50466002)(76176999)(6916009)(31696002)(38730400002)(77096006)(6486002)(90366009)(74482002)(110136004)(6246003)(4001350100001)(83506001)(8666007)(53936002)(230700001)(189998001)(4326008)(54906002)(53546009)(66066001)(3260700006)(25786009)(117156002)(47776003)(23676002)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0202MB2551;H:[192.168.0.125];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjAyMDJNQjI1NTE7MjM6d05hUTVGa2RFdFdwMEM1Mmh3YURENSts?= =?utf-8?B?K3hZUnhjdk9vN1l0dWp0S2dkWnVTWWppL2x3WkJWcjVYSmw0Qnpwa3JUaEVj?= =?utf-8?B?bTNpU2Vvc05hTWhHVlQwL3o4Y0ZGdUZkWTNIN2pOYWhsVHk0TzhlU2xlVjdr?= =?utf-8?B?SWdHNTZpQ1pvNEtmWGxtbHRsbG4xS1NZR3l5L1UvV0ZUM3FhUEFOaXJ0aWd5?= =?utf-8?B?TmFkTnNtUTcxN2xyamJYSnRicjJTTWFtUnRkbFFjem9la0ppd09OQlVxRmpT?= =?utf-8?B?S2owTjVsYVBVa3lua2s5QW0vYXFuRGZuTTdXbGRvZEZHRWxyWElYYkE1b3Qr?= =?utf-8?B?aWc4SUwyNUl6YnMydGtuSVBlVnJ3UktuU1pOaHkwandXL084SDZNa3dISndC?= =?utf-8?B?S0VyamxRWGFJN0N4WU9Mc2Y5aURRUk9lTXZFMjJIaTNBZGR1Z3hyUndtN2dS?= =?utf-8?B?UGFyd0s3RC80Qno5SWZ0UHV3cjRUYzNpNmk1bHc2RENCdnJQTVJqVGFNQnZM?= =?utf-8?B?QjAxcjY0NSt2c0k1UW9Db0ZFNmRndjlIWmY1TUhVcFZPbGFIUElzSmFSZHFw?= =?utf-8?B?VE9tOVFFeGMydzc1QSthQmVGUUcxcVduRTFtZTl5amphd20vY0dLeXdzOFdv?= =?utf-8?B?SEtPd0V5U21CbFBHRGdrY2gya1F0TWljMVh1VC8xa0ovWkltYi9jOSs4LzhV?= =?utf-8?B?VUorZHFsb2svRXlsSmdnb3l4MklSemFLNkY4RkVQbThCV1F4Y2ZZZUJuTnVo?= =?utf-8?B?TVR3T3ByRGc5OUx0ZmhXaWZpNVZJdU1pTEhLWHVxR3hqcDQzbGJwZm50bSsv?= =?utf-8?B?RGlHREM4K2lTNWd6VFNrTzFIVXZqM3VkYUxSdDZ5VytSSEUwZzJSWGxpbzFX?= =?utf-8?B?YndSeEFXM3ZKQkw5M1F0dE4za09mNWNRazZtMVR6aU82U3Azb1puMTB1Zm5W?= =?utf-8?B?Mllka0RPWmJyWWJ0NndLa2drcm1KdzZnVVdqNDk3S2hYZG5LbForQ3NXdzZK?= =?utf-8?B?R1dhc242NFBvWXRLSFl2c0RxdXlOVHVTQ3FTM0dIanlOWXN1U3AraE9vQkZY?= =?utf-8?B?NEVmVGd4TUJKN3VZUFd4YnVwd24reHZvRWF2Q2VLNVhzdnUzNTZrMTQvVUN0?= =?utf-8?B?ZURJRGZDa0JYNkFWbDZIay80bnFTWFNSd1BKbTAwTzhYUUxjMG9QMWdSWnJn?= =?utf-8?B?Z1hPT3UzTmpubnliT0pVNC9QQkdJU1MxcWJsSUM5L0xPVkFZL2gxMk9ibzZM?= =?utf-8?B?UmFucUI0THdjaENxa3pRVjBwUFFGVUplRmlIT1NtUHIrS1VtcHJWalNkQWgz?= =?utf-8?B?ZDk2TVpyYlBVVnYvSWZhVUtHUlFWRGVzMHBYMGpLaVUrNStlNEU4VzFTVEZi?= =?utf-8?B?NEtBZGFhWUxFUkw4cVNyQnhPNVFsekE0emY5eDVNVzhKMTBnU0dNMkErMVg2?= =?utf-8?B?TmNlNExjLzE4Nmw0MVV1NHc5QVVRTEhXeGErSk9GTGZUOHVXUXllY2M0QW5l?= =?utf-8?B?aFptQ0taeFNpc0puREJOa3l4LzRSREY5Rk1IWG4wVkpaeXBVSlg4Y29rVFZs?= =?utf-8?B?ZHNIWXlVSnNScWpzTVdyNWhMK0wwUStBb2pVdml0UkxieG80TFcwQXRrdGM0?= =?utf-8?B?K2o2bzN1ZytuMVFSVit2M3VaWDcrOEJYem8xYTUveUFVYkVqTHVIbWx6Zlp0?= =?utf-8?B?c29ONjVaWEFNRlQyUlRRVW1hSVRtYnE1LzYwNTkxczJIWFVTUStrN0gwUzdV?= =?utf-8?B?c1hkZGZIbExvWVNtWlc1Y2o4ZVF0alNkSGV6bGYxdTRieTh6SzhpTUVadDkr?= =?utf-8?B?b0h5LzhpdlFjNEt0TEhvWUtoOXBTRnFkWGpKa2xVVk9TMnk0Zz09?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0202MB2551;6:m4E7/S8YnWHD4K5paFr5gUAKuWiFSZkW5x7YpakSRQ3ZxZGug24rfwjm3EMWs2Pdwripcbys+ofm7QvIcR4c4A1YPEY+FJ4ZVmyCc+fHU9BcjMqeZ4PZaWocyeeUn0DLUh3qzNe2O7hsFrjSyDaY5xCHqtPgt+pCOBXb9jz/gvMs8ZytIRiqzVBjge+lHZFW02Ok9pPaB9KDvvrq+FHRXOIGOpkKkHJp6jh2TvkIKcyJYCLVYZj3OJUwXL2Gbpfb+dkgWgD6I06GYDfKBOo1U1Bx7y531ljd6caALZJZJVotmF1zyHoX+AMCWNVQZtPSJywTkWPJIbOOIuVK/IbKnsePPsW1l3jsStHhkmu/dm8Q+zpkbUIG3bpL0Kh0fyF46Fo4l+OJQfO2y0NXNduR1QUGd1+MTMDaAvfwhx+t346EOzTsVikBSOlDSAp5W1jhsupkShuoBSm0kE+roobECeeHgIO7+B6AdEsQK2wGYv0NXT1+tK6Rl1neqEmEPN/ckykVc+hgygcyXAimnn9W/g==;5:+lKk1ZL8Re+YJ3dE82gzTMSnCEHGT388g+c30LYuJoCSsKaHiwlR+9Sltlzx7j+yKgQ8TWmorkMQZpNOgah13WJPEf73mrKKWIu/cG/+spqey0ZejJpUiFGbxjLawzgHIYlIW0OQZrloS9Ba42tADQ==;24:TP8uowTK5fL1iz99lWh7FqmrglfOAJ3eTypPAznXmcoH7+2IO7iEFrSN5CRrDBRv9sVta2x392LPxoGDdV17u1jYVrPZljDJ/jvYyGmZgmY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0202MB2551;7:ecgN3zFS8n+9EhWC+R3AcroiCVrK57VWmgrIbkuoJaTiZOrN9jcXZM1KSFrR+nfe8MMcz2fH5S4wzFQ6jTe/xQVneofIo+DJq3fM7RD3xT76UP3Y/wbxdjruRJdAZ+thGb9MWePvrT4JYS60n1JYrt/P5aKoQ50iAmgaYRXdEa18SPs+TXfkpozCRmWwoEIVMnvcnYd6cMgdP0Q65r+SdGJVmUtemY6aqQz7GOffROtE+4Q2TDC6oWGxYqw/wltByNLEiODgDD9i4yYc7Td/Php0tbjmR0ysyko1ya3tYNGdcN2BHNX4Kr+FuGdfliwPViDhWgsJ33YC55dxZUqgsA== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2017 15:08:20.7255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0202MB2551 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-04-21 16:18, Philipp Zabel wrote: > Hi Peter, > > On Thu, 2017-04-13 at 18:43 +0200, Peter Rosin wrote: > [...] >> +int mux_control_select(struct mux_control *mux, int state) > > state could be unsigned int for the consumer facing API. > >> +{ >> + int ret; > > And mux_control_select should check that (0 <= state < mux->states). Yes, that makes sense. I worried that we might end up with signed/unsigned comparisons since the internal state still needs to be signed, but that didn't happen when I tried... I'll include this change in v14. Cheers, peda