From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F85FC4320A for ; Thu, 29 Jul 2021 10:52:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74EE560C40 for ; Thu, 29 Jul 2021 10:52:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236226AbhG2Kw7 (ORCPT ); Thu, 29 Jul 2021 06:52:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233413AbhG2Kw6 (ORCPT ); Thu, 29 Jul 2021 06:52:58 -0400 Received: from m-r1.th.seeweb.it (m-r1.th.seeweb.it [IPv6:2001:4b7a:2000:18::170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D123CC061765; Thu, 29 Jul 2021 03:52:55 -0700 (PDT) Received: from [192.168.1.101] (83.6.168.174.neoplus.adsl.tpnet.pl [83.6.168.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 50DF2200C6; Thu, 29 Jul 2021 12:52:50 +0200 (CEST) Subject: Re: [PATCH 14/39] arm64: dts: qcom: sdm630: Add TSENS node To: Thara Gopinath , ~postmarketos/upstreaming@lists.sr.ht Cc: martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Andy Gross , Bjorn Andersson , Amit Kucheria , Zhang Rui , Daniel Lezcano , Rob Herring , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210728222542.54269-1-konrad.dybcio@somainline.org> <20210728222542.54269-15-konrad.dybcio@somainline.org> <860f1120-c5a4-f531-3ea9-aa90c6b063dc@linaro.org> From: Konrad Dybcio Message-ID: <2318377c-959a-a42b-81b5-44e2629570d5@somainline.org> Date: Thu, 29 Jul 2021 12:52:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <860f1120-c5a4-f531-3ea9-aa90c6b063dc@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.07.2021 12:50, Thara Gopinath wrote: > Hi Konrad, > > On 7/28/21 6:25 PM, Konrad Dybcio wrote: >> This will enable temperature reporting for various SoC >> components. >> >> Signed-off-by: AngeloGioacchino Del Regno >> Signed-off-by: Konrad Dybcio >> --- >>   .../devicetree/bindings/thermal/qcom-tsens.yaml       |  1 + >>   arch/arm64/boot/dts/qcom/sdm630.dtsi                  | 11 +++++++++++ >>   2 files changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> index 4a2eaf28e3fd..d3b9e9b600a2 100644 >> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> @@ -48,6 +48,7 @@ properties: >>                 - qcom,sc7180-tsens >>                 - qcom,sc7280-tsens >>                 - qcom,sc8180x-tsens >> +              - qcom,sdm630-tsens >>                 - qcom,sdm845-tsens >>                 - qcom,sm8150-tsens >>                 - qcom,sm8250-tsens >> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi >> index 1e54828817d5..7e9c80e35fba 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi >> @@ -627,6 +627,17 @@ mnoc: interconnect@1745000 { >>                    <&mmcc AHB_CLK_SRC>; >>           }; >>   +        tsens: thermal-sensor@10ae000 { >> +            compatible = "qcom,sdm630-tsens", "qcom,tsens-v2"; >> +            reg = <0x010ae000 0x1000>, /* TM */ >> +                  <0x010ad000 0x1000>; /* SROT */ >> +            #qcom,sensors = <12>; > > Are all 12 sensors used ? I see that in a later patch "arm64: dts: qcom: sdm630: Add thermal-zones configuration" only 9 are used. Hi, if I recall correctly, they all give output but not all of the mappings were documented in the downstream sources and we have no documentation whatsoever :( Konrad