From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69FAAC433EF for ; Thu, 7 Apr 2022 13:15:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343616AbiDGNRJ (ORCPT ); Thu, 7 Apr 2022 09:17:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239126AbiDGNRF (ORCPT ); Thu, 7 Apr 2022 09:17:05 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E0E001B5380 for ; Thu, 7 Apr 2022 06:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649337302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=udxygKvlwgxmrvFQRGMm3xyqxn601rj4KdSJI9OKca0=; b=DgW8qTVVQekRGx7ztAoqJcHClkbRZp88ee83qbUi6KaRQjK9/rD7Vs7B1YOToanS+6DtAM yLZnudggnRcb6K1VOWKPIX6QI6qpCaYA7kkIqzgBQOuNOgPVGFyTLYjnIL9Km8yC3JJZPU JoDAMAhFrcErxEzAWFjSksZu8qwXvIM= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-615-DksiJ0tUO2CheWfRVyV7XQ-1; Thu, 07 Apr 2022 09:15:01 -0400 X-MC-Unique: DksiJ0tUO2CheWfRVyV7XQ-1 Received: by mail-ej1-f71.google.com with SMTP id m12-20020a1709062acc00b006cfc98179e2so3055767eje.6 for ; Thu, 07 Apr 2022 06:15:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=udxygKvlwgxmrvFQRGMm3xyqxn601rj4KdSJI9OKca0=; b=1QiqDzrzhjqJ3EtGJYwvH2/SIprwcK+xfZ/K8zeEI7HUx5afanRbbMZZWtjraLo5Vy 2iBlr1RVXczH/ot8ftdOOll1mLYnrxXZThBYsNuqKJxbXnpyt1X+BEXFXxfdIqAyyXIu IXUB6NJajnHR1QUvYYOxJBZDhlY3CIWfqJOo+qX/YRUH4zA6MkH8topsHHFRpGyXqqwS T01a0Q4jPAxPhPpJHW7FIKoMovt5zujC9+guZGGQqyA7L4vcdWgePALYiAeSOs6DyQOL hkONJLhjK2d/DKPJlYtmWKR5WKRz9MeRVyA9z7qEvLLxMIP4JFkSxpFYZBNlAxK/1KQv p8EA== X-Gm-Message-State: AOAM532QKdGA97QAFkXPTMSt3l7j+U3Ss5iTm1dRnJMlAo+gsLbdwrFS JI841s4xnHgZkrB5V9+zY+AiTQnM2MsdePp8t5n1Hm1NzKirAxXMEfpFvOOM5eQcZkLEAdmSE11 xYlhHlRcER0x0iDre01BucelN X-Received: by 2002:a17:907:1c20:b0:6e4:b753:93fc with SMTP id nc32-20020a1709071c2000b006e4b75393fcmr13277230ejc.363.1649337299503; Thu, 07 Apr 2022 06:14:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmZYQ3ay23HA1zsX8EaoXjDU6Mev9H0qIxUfrwm2VhF2YVOmFSt7Z/m1lFcvcz8wEQHikrsw== X-Received: by 2002:a17:907:1c20:b0:6e4:b753:93fc with SMTP id nc32-20020a1709071c2000b006e4b75393fcmr13277200ejc.363.1649337299226; Thu, 07 Apr 2022 06:14:59 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id d12-20020a50cf4c000000b0041cc12dc1f3sm6542752edk.71.2022.04.07.06.14.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 06:14:58 -0700 (PDT) Message-ID: <23189be4-4410-d47e-820c-a3645d5b9e6d@redhat.com> Date: Thu, 7 Apr 2022 15:14:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC PATCH v5 089/104] KVM: TDX: Add a placeholder for handler of TDX hypercalls (TDG.VP.VMCALL) Content-Language: en-US To: Kai Huang , isaku.yamahata@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: isaku.yamahata@gmail.com, Jim Mattson , erdemaktas@google.com, Connor Kuehl , Sean Christopherson References: <3042130fce467c30f07e58581da966fc405a4c6c.camel@intel.com> From: Paolo Bonzini In-Reply-To: <3042130fce467c30f07e58581da966fc405a4c6c.camel@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/7/22 06:15, Kai Huang wrote: >> >> +static int handle_tdvmcall(struct kvm_vcpu *vcpu) >> +{ >> + struct vcpu_tdx *tdx = to_tdx(vcpu); >> + >> + if (unlikely(tdx->tdvmcall.xmm_mask)) >> + goto unsupported; > Put a comment explaining this logic? > This only seems to be necessary for Hyper-V hypercalls, which however are not supported by this series in TDX guests (because the kvm_hv_hypercall still calls kvm_*_read, likewise for Xen). So for now this conditional can be dropped. Since