From: Adrian Hunter <adrian.hunter@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Leo Yan <leo.yan@linaro.org>,
Kan Liang <kan.liang@linux.intel.com>,
x86@kernel.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] perf intel-pt: Add PEBS-via-PT side-band
Date: Mon, 21 Jun 2021 09:15:10 +0300 [thread overview]
Message-ID: <23211445-d02b-2b6c-a72c-6bf9b412798d@intel.com> (raw)
In-Reply-To: <20210609142055.32226-1-adrian.hunter@intel.com>
On 9/06/21 5:20 pm, Adrian Hunter wrote:
> Hi
>
> PEBS output to Intel Processor Trace was introduced with Atom
> processors based on Tremont. Currently there is software support
> only for a single PEBS-via-PT event.
>
> Here is support for multiple PEBS-via-PT events.
Any comments on this patch set?
>
> The first patch is the kernel change which adds a new event,
> namely PERF_RECORD_AUX_OUTPUT_HW_ID which contains the counter
> index. That is output when the PEBS-via-PT event is enabled in hardware.
> There is an optimization, to report the index only when it changes
> for the event. That will work only so long as all PEBS-via-PT
> events are scheduled together, which they are for a recording
> session because they are in a single group.
>
> Also no attribute bit is used to select the new event, so a new
> kernel is not compatible with older perf tools. The assumption
> being that PEBS-via-PT is sufficiently esoteric that users will not
> be troubled by this.
>
> The second patch adds the usual boiler plate to perf tools for
> a new event.
>
> The third patch adds support for processing the new event by
> perf tool's Intel PT decoder.
>
>
> Adrian Hunter (3):
> perf/x86: Add new event for AUX output counter index
> perf tools: Add support for PERF_RECORD_AUX_OUTPUT_HW_ID
> perf intel-pt: Add support for PERF_RECORD_AUX_OUTPUT_HW_ID
>
> arch/x86/events/core.c | 1 +
> arch/x86/events/intel/ds.c | 16 ++++++
> include/linux/perf_event.h | 2 +
> include/uapi/linux/perf_event.h | 15 ++++++
> kernel/events/core.c | 30 +++++++++++
> tools/include/uapi/linux/perf_event.h | 15 ++++++
> tools/lib/perf/include/perf/event.h | 6 +++
> tools/perf/Documentation/perf-intel-pt.txt | 7 ++-
> tools/perf/builtin-inject.c | 4 +-
> tools/perf/builtin-record.c | 2 +-
> tools/perf/util/event.c | 18 +++++++
> tools/perf/util/event.h | 5 ++
> tools/perf/util/intel-pt.c | 85 ++++++++++++++++++++++++++++--
> tools/perf/util/machine.c | 10 ++++
> tools/perf/util/machine.h | 2 +
> tools/perf/util/session.c | 5 ++
> tools/perf/util/tool.h | 1 +
> 17 files changed, 217 insertions(+), 7 deletions(-)
>
>
> Regards
> Adrian
>
prev parent reply other threads:[~2021-06-21 6:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 14:20 [PATCH 0/3] perf intel-pt: Add PEBS-via-PT side-band Adrian Hunter
2021-06-09 14:20 ` [PATCH 1/3] perf/x86: Add new event for AUX output counter index Adrian Hunter
2021-06-25 12:06 ` Peter Zijlstra
2021-06-25 13:15 ` Peter Zijlstra
2021-06-30 9:21 ` Adrian Hunter
2021-06-30 11:04 ` Peter Zijlstra
2021-06-09 14:20 ` [PATCH 2/3] perf tools: Add support for PERF_RECORD_AUX_OUTPUT_HW_ID Adrian Hunter
2021-06-09 14:20 ` [PATCH 3/3] perf intel-pt: " Adrian Hunter
2021-06-21 6:15 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23211445-d02b-2b6c-a72c-6bf9b412798d@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).